From owner-freebsd-firewire@FreeBSD.ORG Tue Aug 12 01:07:30 2008 Return-Path: Delivered-To: freebsd-firewire@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 82E391065687; Tue, 12 Aug 2008 01:07:30 +0000 (UTC) (envelope-from sbruno@miralink.com) Received: from plato.miralink.com (mail.miralink.com [70.103.185.20]) by mx1.freebsd.org (Postfix) with ESMTP id 501678FC08; Tue, 12 Aug 2008 01:07:30 +0000 (UTC) (envelope-from sbruno@miralink.com) Received: from localhost (localhost.localdomain [127.0.0.1]) by plato.miralink.com (Postfix) with ESMTP id E5C521A90E6; Mon, 11 Aug 2008 18:01:30 -0700 (PDT) X-Virus-Scanned: amavisd-new at X-Spam-Flag: NO X-Spam-Score: -4.399 X-Spam-Level: X-Spam-Status: No, score=-4.399 tagged_above=-10 required=6.6 tests=[ALL_TRUSTED=-1.8, BAYES_00=-2.599] Received: from plato.miralink.com ([127.0.0.1]) by localhost (plato.miralink.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7ln9Ev1PrSQ5; Mon, 11 Aug 2008 18:01:30 -0700 (PDT) Received: from [10.47.1.6] (vpn.office.miralink.com [10.0.0.5]) by plato.miralink.com (Postfix) with ESMTP id F1F3D1A90B0; Mon, 11 Aug 2008 18:01:29 -0700 (PDT) Message-ID: <48A0E237.5020702@miralink.com> Date: Mon, 11 Aug 2008 18:07:03 -0700 From: Sean Bruno User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Dieter References: <200808120033.AAA07139@sopwith.solgatos.com> In-Reply-To: <200808120033.AAA07139@sopwith.solgatos.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Scott Long , freebsd-firewire@freebsd.org Subject: Re: This is where I'm going with fwcontrol X-BeenThere: freebsd-firewire@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Firewire support in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2008 01:07:30 -0000 Dieter wrote: >> Also, I changed some of the variable to check for >= 0 and set their >> default values to -1. This should have the same effect as adding a new >> variable as you did in your fix. >> > > If you're going to do it that way, the code should check that the argument > is in range, and print a complaint if out of range. Otherwise the user could > say "fwcontrol -f -1" and nothing would happen. And the man page should list > the legal range. Hmmm, actually these should be done even with the > add-a-new-variable method. > Excellent feedback, let me work on something tonight and reissue the patch. -- Sean Bruno MiraLink Corporation 6015 NE 80th Ave, Ste 100 Portland, OR 97218 Cell 503-358-6832 Phone 503-621-5143 Fax 503-621-5199 MSN: sbruno@miralink.com Google: seanwbruno@gmail.com