From owner-svn-src-all@freebsd.org Fri Oct 2 01:23:55 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 379243F18A1; Fri, 2 Oct 2020 01:23:55 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C2XMF6jBLz3y0p; Fri, 2 Oct 2020 01:23:53 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id O9nak5eGoHxtDO9nbkOUjV; Thu, 01 Oct 2020 19:23:52 -0600 X-Authority-Analysis: v=2.4 cv=Ce22WJnl c=1 sm=1 tr=0 ts=5f768128 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=afefHYAZSVUA:10 a=6I5d2MoRAAAA:8 a=IP17e_1XAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=qBuU5bC0W9aZ4l6sTV8A:9 a=CjuIK1q_8ugA:10 a=71KNwuU-lXsA:10 a=DoawHyg_QpkA:10 a=-RoEEKskQ1sA:10 a=IjZwj45LgO3ly-622nXo:22 a=pIDkZDmBs-rV6VORH8mB:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id B15E4108; Thu, 1 Oct 2020 18:23:49 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 0921NnJU006207; Thu, 1 Oct 2020 18:23:49 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202010020123.0921NnJU006207@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Kyle Evans cc: Ed Maste , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r366344 - in head: lib/libmd sys/crypto/skein/amd64 In-reply-to: References: <202010012105.091L5pAn099334@repo.freebsd.org> Comments: In-reply-to Kyle Evans message dated "Thu, 01 Oct 2020 20:18:11 -0500." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 01 Oct 2020 18:23:49 -0700 X-CMAE-Envelope: MS4xfLc4qTtp8y8AXOq0F9SOfUAQd5gY66TpR7Kc4HB4LpDOxq8HNFoNbjZhMBxP1Y8XmPk+T17HZpztzmWU4Y64lkF3++IGHKY/sEIWQVBHdJirIKrm45hg b4he6sl5FjhBSglzjdEBYvCUNcTl2gs9oGU2gUPX5cQzAD5JDJvCjXW2lJVEch/dZLx6ZV0koaEGJHk3a8r1pycloFo8VFrKs8M4vnBk4NuaUQspF0jRQc2d Uk+oQnx6GpZDZqH+MkuLeXYonoa+PN79ec4VnnGGjpWu1/uwL/yINdCx9dool9dNCZb+LYC4P3A7XcyQO/WQAlkzPkO/C1VnsRJh8LoqbeE= X-Rspamd-Queue-Id: 4C2XMF6jBLz3y0p X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.136.139) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [0.07 / 15.00]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-0.34)[-0.336]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; ARC_NA(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-0.41)[-0.415]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.48)[-0.476]; RECEIVED_SPAMHAUS_PBL(0.00)[70.67.125.17:received]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; RCVD_IN_DNSWL_LOW(-0.10)[64.59.136.139:from] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 01:23:55 -0000 In message , Kyle Evans writes: > On Thu, Oct 1, 2020 at 4:06 PM Ed Maste wrote: > > > > Author: emaste > > Date: Thu Oct 1 21:05:50 2020 > > New Revision: 366344 > > URL: https://svnweb.freebsd.org/changeset/base/366344 > > > > Log: > > libmd: fix assembly optimized skein implementation > > > > The assembly implementation incorrectly used logical AND instead of > > bitwise AND. Fix, and re-enable in libmd. > > > > Submitted by: Yang Zhong > > Reviewed by: cem (earlier) > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D26614 > > > > Modified: > > head/lib/libmd/Makefile > > head/sys/crypto/skein/amd64/skein_block_asm.S > > > > Modified: head/lib/libmd/Makefile > > =========================================================================== > === > > --- head/lib/libmd/Makefile Thu Oct 1 20:08:27 2020 (r366343) > > +++ head/lib/libmd/Makefile Thu Oct 1 21:05:50 2020 (r366344) > > @@ -116,12 +116,12 @@ CFLAGS+= -DSHA1_ASM > > SRCS+= rmd160.S > > CFLAGS+= -DRMD160_ASM > > .endif > > -#.if exists(${MACHINE_ARCH}/skein_block_asm.S) > > -## Fully unroll all loops in the assembly optimized version > > -#ACFLAGS+= -DSKEIN_LOOP=0 > > -#SRCS+= skein_block_asm.S > > -#CFLAGS+= -DSKEIN_ASM -DSKEIN_USE_ASM=1792 # list of block functions to re > place with assembly: 256+512+1024 = 1792 > > -#.endif > > +.if exists(${MACHINE_ARCH}/skein_block_asm.S) > > +# Fully unroll all loops in the assembly optimized version > > +ACFLAGS+= -DSKEIN_LOOP=0 > > +SRCS+= skein_block_asm.S > > +CFLAGS+= -DSKEIN_ASM -DSKEIN_USE_ASM=1792 # list of block functions to rep > lace with assembly: 256+512+1024 = 1792 > > +.endif > > .if exists(${MACHINE_ARCH}/sha.S) || exists(${MACHINE_ARCH}/rmd160.S) || e > xists(${MACHINE_ARCH}/skein_block_asm.S) > > ACFLAGS+= -DELF -Wa,--noexecstack > > .endif > > > > We need some kind of magic to walk across this for -DNO_CLEAN builds > -- skein_block.c has no reason to get rebuilt, but we need it to > because we're now defining SKEIN_USE_ASM=1792, which will strip out > some symbols. > > I haven't had time to look into what kind of magic we can apply here, > kind of needed to skip ahead to get this build finished for some other > testing. I did rm -r for .../lib/libmd. Strangely it only failed in the amd64 build. Not in i386. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.