From owner-freebsd-fs@FreeBSD.ORG Wed Aug 6 14:18:00 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37BF7106566B for ; Wed, 6 Aug 2008 14:18:00 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.226]) by mx1.freebsd.org (Postfix) with ESMTP id E24088FC22 for ; Wed, 6 Aug 2008 14:17:59 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by wx-out-0506.google.com with SMTP id h27so488191wxd.7 for ; Wed, 06 Aug 2008 07:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=G9l3rIqpM0DaYGqBrkTGbWwfyDI//9C4113QPsIiWEc=; b=XEuGm8gNAvtmljSEbb8AmtxKnWNQtvCOI6d+mXaDiH9RNEI933YxrQviYrceMf5NAL r4Bwfj4s3+0AAd0mXC9L3Z9buybT4Eit9ybZTBD++x9h/hiCYqMhXo/f9hKTOLIm0fP/ RwA1xNL3OM8VH//1CfIZyaX6a3XCdY/kFaOro= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=NjSG/LS9m5aUfF4nPBkrDBEgoAh1k6X7pAG8jCHvhsjbe7ZGJzSiyrTfa3gvR4bGSk AuTGeEGlIZ0uZwW/StyfMRCRVRzsqonxNQizTW/Kdt0GKJCzCydQGoFjOfjyTMHhT/Us DfkonSepImO8+z97xJZQKXpMn0gtZpHAuvNbc= Received: by 10.100.247.14 with SMTP id u14mr1805565anh.89.1218030744867; Wed, 06 Aug 2008 06:52:24 -0700 (PDT) Received: by 10.100.42.12 with HTTP; Wed, 6 Aug 2008 06:52:24 -0700 (PDT) Message-ID: Date: Wed, 6 Aug 2008 15:52:24 +0200 From: "Mateusz Guzik" To: "Kostik Belousov" In-Reply-To: <20080806133441.GM97161@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200808061020.m76AK5NI013323@freefall.freebsd.org> <20080806133441.GM97161@deviant.kiev.zoral.com.ua> Cc: freebsd-fs@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Aug 2008 14:18:00 -0000 2008/8/6 Kostik Belousov : > On Wed, Aug 06, 2008 at 10:20:05AM +0000, Mateusz Guzik wrote: >> The following reply was made to PR kern/126287; it has been noted by GNATS. >> >> From: "Mateusz Guzik" >> To: bug-followup@freebsd.org >> Cc: >> Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled >> Date: Wed, 6 Aug 2008 12:15:00 +0200 >> >> Something weird happened to my attachment, I'll paste it here: >> >> --- sys/kern/vfs_mount.c.orig 2008-08-06 11:14:16.000000000 +0200 >> +++ sys/kern/vfs_mount.c 2008-08-06 11:14:32.000000000 +0200 >> @@ -196,10 +196,13 @@ >> void >> vfs_deleteopt(struct vfsoptlist *opts, const char *name) >> { >> struct vfsopt *opt, *temp; >> >> + if (opts == NULL) >> + return; >> + >> TAILQ_FOREACH_SAFE(opt, opts, link, temp) { >> if (strcmp(opt->name, name) == 0) >> vfs_freeopt(opts, opt); >> } >> } >> >> Again, it should work fine ;) > > The PR lacks the backtrace (preferrable the ddb output or "bt full" from > kgdb) for the panic. Please, show me the backtrace. > Sorry, I don't have currently access to fbsd 7, so here is backtrace from CURRENT(crashed by mount -o snapshot /somefilesystem): [..] #11 0xc06e1e5b in calltrap () at /srv/build/CURRENT/src/sys/i386/i386/exception.s:165 #12 0xc05c86d4 in vfs_deleteopt (opts=0x0, name=0xc074ef52 "snapshot") at /srv/build/CURRENT/src/sys/kern/vfs_mount.c:195 #13 0xc068d689 in ffs_mount (mp=0xc29f52a0, td=0xc2875af0) at /srv/build/CURRENT/src/sys/ufs/ffs/ffs_vfsops.c:172 #14 0xc05cb1d8 in vfs_donmount (td=0xc2875af0, fsflags=0, fsoptions=0xc261db80) at /srv/build/CURRENT/src/sys/kern/vfs_mount.c:1010 #15 0xc05cc3bb in nmount (td=0xc2875af0, uap=0xcd3a7cf8) at /srv/build/CURRENT/src/sys/kern/vfs_mount.c:417 #16 0xc06f9157 in syscall (frame=0xcd3a7d38) at /srv/build/CURRENT/src/sys/i386/i386/trap.c:1081 #17 0xc06e1ef0 in Xint0x80_syscall () at /srv/build/CURRENT/src/sys/i386/i386/exception.s:261 Thanks, -- Mateusz Guzik