Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Mar 2006 17:48:33 -0500
From:      Frank Laszlo <laszlof@vonostingroup.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        portmgr@FreeBSD.org
Subject:   ports/95085: [PATCH]: Add knob to allow for mutually exclusive OPTIONS
Message-ID:  <E1FOjSr-000CHU-8U@ritamari.vonostingroup.com>
Resent-Message-ID: <200603292250.k2TMo9jA012116@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         95085
>Category:       ports
>Synopsis:       [PATCH]: Add knob to allow for mutually exclusive OPTIONS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 29 22:50:08 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Frank Laszlo
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD ritamari.vonostingroup.com 6.0-STABLE FreeBSD 6.0-STABLE #0: Mon Nov 7 12:06:15 EST 2005 laszlof@ritamari.vonostingroup.com:/usr/obj/usr/src/sys/RITAMARI i386


	
>Description:
	This is a small patch to allow for DIALOG to use the --radiolist option. This will allow port maintainers to
	create mutually exclusive port options. I have added an 'OPTIONS_RADIO' knob to enable this feature. I have CC'd
	portmgr as I believe it falls under their territory.

>How-To-Repeat:
	
>Fix:

	



--- bsd.port.mk.diff begins here ---
--- bsd.port.mk.orig	Wed Mar 29 17:30:40 2006
+++ bsd.port.mk	Wed Mar 29 17:43:28 2006
@@ -685,6 +685,8 @@
 #				  into a single variable.  NOTE: To make options work, you need
 #				  to include bsd.port.pre.mk before you start testing the
 #				  WITH_xyz variables.
+# OPTIONS_RADIO		- Use the "--radiolist" option with DIALOG rather than the default
+#				  "--checklist" to allow for mutually exclusive options.
 #
 # For fetch:
 #
@@ -1166,6 +1168,11 @@
 .	if exists(${_OPTIONSFILE}.local)
 .	include "${_OPTIONSFILE}.local"
 .	endif
+.	if defined(OPTIONS_RADIO)
+DIALOG_FLAGS+=	--radiolist
+.	else
+DIALOG_FLAGS+=	--checklist
+.	endif
 .endif
 
 # check for old, crufty, makefile types, part 1:
@@ -5247,7 +5254,7 @@
 	done; \
 	TMPOPTIONSFILE=$$(mktemp -t portoptions); \
 	trap "${RM} -f $${TMPOPTIONSFILE}; exit 1" 1 2 3 5 10 13 15; \
-	${SH} -c "${DIALOG} --checklist \"Options for ${PKGNAME:C/-([^-]+)$/ \1/}\" 21 70 15 $${DEFOPTIONS} 2> $${TMPOPTIONSFILE}"; \
+	${SH} -c "${DIALOG} ${DIALOG_FLAGS} \"Options for ${PKGNAME:C/-([^-]+)$/ \1/}\" 21 70 15 $${DEFOPTIONS} 2> $${TMPOPTIONSFILE}"; \
 	status=$$?; \
 	if [ $${status} -ne 0 ] ; then \
 		${RM} -f $${TMPOPTIONSFILE}; \
--- bsd.port.mk.diff ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1FOjSr-000CHU-8U>