From owner-freebsd-current@FreeBSD.ORG  Mon Aug  3 07:26:14 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 86FB11065670
	for <freebsd-current@freebsd.org>; Mon,  3 Aug 2009 07:26:14 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe13.tele2.se [212.247.155.129])
	by mx1.freebsd.org (Postfix) with ESMTP id 199AE8FC13
	for <freebsd-current@freebsd.org>; Mon,  3 Aug 2009 07:26:13 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=6I5d2MoRAAAA:8
	a=E59DoiNZAK6uQHgO13YA:9 a=L6P8scQk6huVf71Asn8A:7
	a=pAl1FcrUv4Exu3WZBfaAV1zbvCsA:4 a=Rk7U24iObsvedVEAsQEA:9
	a=gnrMiKeQK1jmmxtyE0cA:7 a=AN3LayuI9UxRzUdBw6P6GySq-W0A:4
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop.adsl.tele2.no)
	by mailfe13.swip.net (CommuniGate Pro SMTP 5.2.13)
	with ESMTPA id 900987259 for freebsd-current@freebsd.org;
	Mon, 03 Aug 2009 09:26:12 +0200
To: freebsd-current@freebsd.org
Content-Disposition: inline
From: Hans Petter Selasky <hselasky@c2i.net>
Date: Mon, 3 Aug 2009 09:26:10 +0200
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_UEpdKHFUUlIBNl5"
Message-Id: <200908030926.12472.hselasky@c2i.net>
Subject: Patch to address coredump slowdown
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2009 07:26:14 -0000

--Boundary-00=_UEpdKHFUUlIBNl5
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

The following attached patch addresses recently slowed coredumps.

http://perforce.freebsd.org/chv.cgi?CH=166957

MD5 (ukbd.c.diff) = 1e3c143942593b0ed4617d306a9d2ee2

cd /usr/src/sys/dev/usb/input/
cat ukbd.c.diff | patch

--HPS


--Boundary-00=_UEpdKHFUUlIBNl5
Content-Type: text/x-patch;
  charset="iso-8859-1";
  name="ukbd.c.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
	filename="ukbd.c.diff"

--- ukbd.c	2009-08-02 16:28:40.000000000 +0200
+++ ukbd.c	2009-08-03 09:12:42.000000000 +0200
@@ -170,6 +170,7 @@
 	int32_t	sc_state;		/* shift/lock key state */
 	int32_t	sc_accents;		/* accent key index (> 0) */
 
+	uint16_t sc_microtime;		/* used when polling */
 	uint16_t sc_inputs;
 	uint16_t sc_inputhead;
 	uint16_t sc_inputtail;
@@ -302,18 +303,32 @@
 static void
 ukbd_do_poll(struct ukbd_softc *sc, uint8_t wait)
 {
+	struct timeval tv;
+	uint16_t temp;
+
 	DPRINTFN(2, "polling\n");
 
 	while (sc->sc_inputs == 0) {
 
 		usbd_transfer_poll(sc->sc_xfer, UKBD_N_TRANSFER);
 
-		DELAY(1000);	/* delay 1 ms */
+		microtime(&tv);
 
-		sc->sc_time_ms++;
+		temp = tv.tv_usec / 25000;
 
 		/* support repetition of keys: */
 
+		if (sc->sc_microtime != temp) {
+
+			/* wait for next delta */
+
+			sc->sc_microtime = temp;
+
+			/* 25 milliseconds have passed */
+
+			sc->sc_time_ms += 25;
+		}
+
 		ukbd_interrupt(sc);
 
 		if (!wait)

--Boundary-00=_UEpdKHFUUlIBNl5--