From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 30 13:00:35 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4733F16A4E5 for ; Wed, 30 Aug 2006 13:00:35 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B0F443D45 for ; Wed, 30 Aug 2006 13:00:34 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k7UD0YEW093342 for ; Wed, 30 Aug 2006 13:00:34 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k7UD0YDx093341; Wed, 30 Aug 2006 13:00:34 GMT (envelope-from gnats) Resent-Date: Wed, 30 Aug 2006 13:00:34 GMT Resent-Message-Id: <200608301300.k7UD0YDx093341@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan Sperling Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D2A0B16A4EE for ; Wed, 30 Aug 2006 12:50:31 +0000 (UTC) (envelope-from stsp@stsp.in-berlin.de) Received: from einhorn.in-berlin.de (einhorn.in-berlin.de [192.109.42.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3FC6443E05 for ; Wed, 30 Aug 2006 12:48:36 +0000 (GMT) (envelope-from stsp@stsp.in-berlin.de) Received: from stsp.lan (brln-d9ba64c2.pool.mediaWays.net [217.186.100.194]) (authenticated bits=128) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id k7UCmTn6008464 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Wed, 30 Aug 2006 14:48:31 +0200 Received: from ted.stsp.lan (localhost [127.0.0.1]) by stsp.lan (8.13.6/8.13.6) with ESMTP id k7UClQtl007547 for ; Wed, 30 Aug 2006 14:47:26 +0200 (CEST) (envelope-from stsp@ted.stsp.lan) Received: (from stsp@localhost) by ted.stsp.lan (8.13.6/8.13.6/Submit) id k7UClPbu007546; Wed, 30 Aug 2006 14:47:25 +0200 (CEST) (envelope-from stsp) Message-Id: <200608301247.k7UClPbu007546@ted.stsp.lan> Date: Wed, 30 Aug 2006 14:47:25 +0200 (CEST) From: Stefan Sperling To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/102691: [maintainer update] small fixes for emulators/zsnes X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Stefan Sperling List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2006 13:00:35 -0000 >Number: 102691 >Category: ports >Synopsis: [maintainer update] small fixes for emulators/zsnes >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Wed Aug 30 13:00:33 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Stefan Sperling >Release: FreeBSD 6.1-RELEASE-p5 i386 >Organization: >Environment: System: FreeBSD ted.stsp.lan 6.1-RELEASE-p5 FreeBSD 6.1-RELEASE-p5 #0: Mon Aug 28 22:42:19 CEST 2006 stsp@ted.stsp.lan:/usr/mylocal/obj/usr/src/sys/TED i386 >Description: These are a couple of small fixes and improvements I have accumulated for the emulators/zsnes port: * Heed CFLAGS and CPPFLAGS set in /etc/make.conf. Without this, C/C++ code is not optimised for ${CPUTYPE} but always for i386 instead. CFLAGS were ignored entirely before this update, even though the port contains both C and C++ code. CPPFLAGS were passed to configure but overridden again for the actual compile. * Only search headers and libaries in ${X11BASE} if building with X11 support. This is rather cosmetic, really. * Fix configure script summary to report correct zsnes version. * Fix compiler warnings about __FreeBSD__ being redefined. >How-To-Repeat: >Fix: --- Makefile.orig Wed Aug 9 03:46:18 2006 +++ Makefile Wed Aug 30 14:26:50 2006 @@ -33,14 +33,15 @@ USE_GMAKE= yes GNU_CONFIGURE= yes CONFIGURE_TARGET= --build=${MACHINE_ARCH}-portbld-freebsd${OSREL} -CONFIGURE_ENV= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}" +CONFIGURE_ENV= CFLAGS="${CFLAGS}" CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}" ALL_TARGET= ALL MAN1= zsnes.1 PLIST_FILES= bin/zsnes -CPPFLAGS= -I${LOCALBASE}/include -I${X11BASE}/include -LDFLAGS= -L${LOCALBASE}/lib -L${X11BASE}/lib +CFLAGS+= -I${LOCALBASE}/include +CPPFLAGS+= -I${LOCALBASE}/include +LDFLAGS+= -L${LOCALBASE}/lib .include @@ -49,6 +50,9 @@ PKGNAMESUFFIX= -nox11 .else CONFIGURE_ARGS+=--with-x +CFLAGS+= -I${X11BASE}/include +CPPFLAGS+= -I${X11BASE}/include +LDFLAGS+= -L${X11BASE}/lib .endif .if defined(WITH_OPENGL) @@ -62,6 +66,8 @@ @${REINPLACE_CMD} -e \ 's| -pipe||g ; \ s| -I/usr/local/include||g ; \ + s|^VERSION=1.41|VERSION=${PORTVERSION}|; \ + s| -D__FreeBSD__||g; \ s| -I/usr/include||g ; \ s| -O3 .* -s||g' ${WRKSRC}/configure @${REINPLACE_CMD} -e \ >Release-Note: >Audit-Trail: >Unformatted: