From owner-svn-src-head@freebsd.org Thu Dec 3 08:50:34 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6EBEA3C305; Thu, 3 Dec 2015 08:50:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3E6311BCA; Thu, 3 Dec 2015 08:50:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tB38oSVu043356 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 3 Dec 2015 10:50:28 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tB38oSVu043356 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tB38oSE7043355; Thu, 3 Dec 2015 10:50:28 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 3 Dec 2015 10:50:28 +0200 From: Konstantin Belousov To: Nathan Whitehorn Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291666 - head/libexec/rtld-elf Message-ID: <20151203085028.GH2405@kib.kiev.ua> References: <201512030006.tB306xTa074887@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201512030006.tB306xTa074887@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 08:50:34 -0000 On Thu, Dec 03, 2015 at 12:06:59AM +0000, Nathan Whitehorn wrote: > Author: nwhitehorn > Date: Thu Dec 3 00:06:59 2015 > New Revision: 291666 > URL: https://svnweb.freebsd.org/changeset/base/291666 > > Log: > Fix build on GCC 5.2 where, at least on PPC64, the compiler would "optimize" > the malloc() + memset() in the local implementation of calloc() into a call > to calloc(), helpfully turning it into an infinite loop. Clean up some > unneeded flags on PPC64 while here. > > MFC after: 1 month > > Modified: > head/libexec/rtld-elf/Makefile > > Modified: head/libexec/rtld-elf/Makefile > ============================================================================== > --- head/libexec/rtld-elf/Makefile Thu Dec 3 00:02:01 2015 (r291665) > +++ head/libexec/rtld-elf/Makefile Thu Dec 3 00:06:59 2015 (r291666) > @@ -13,7 +13,7 @@ SRCS= rtld_start.S \ > malloc.c xmalloc.c debug.c libmap.c > MAN= rtld.1 > CSTD?= gnu99 > -CFLAGS+= -Wall -DFREEBSD_ELF -DIN_RTLD > +CFLAGS+= -Wall -DFREEBSD_ELF -DIN_RTLD -fno-builtin > CFLAGS+= -I${SRCTOP}/lib/csu/common > .if exists(${.CURDIR}/${MACHINE_ARCH}) > RTLD_ARCH= ${MACHINE_ARCH} > @@ -22,7 +22,6 @@ RTLD_ARCH= ${MACHINE_CPUARCH} > .endif > CFLAGS+= -I${.CURDIR}/${RTLD_ARCH} -I${.CURDIR} > .if ${MACHINE_ARCH} == "powerpc64" > -CFLAGS+= -mcall-aixdesc I wanted to set -ffreestanding for rtld compilation, but considered it only a minor issue. Could you test this instead of -fno-builtin, please ? > LDFLAGS+= -nostdlib -e _rtld_start > .else > LDFLAGS+= -nostdlib -e .rtld_start