From owner-svn-src-head@freebsd.org Mon Feb 25 18:09:31 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8775F1510EED; Mon, 25 Feb 2019 18:09:31 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9BCDC70F4B; Mon, 25 Feb 2019 18:09:30 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id yKgqgVLLGMKleyKgsg3lmX; Mon, 25 Feb 2019 11:09:22 -0700 X-Authority-Analysis: v=2.3 cv=EsmsUhUA c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=IkcTkHD0fZMA:10 a=CFTnQlWoA9kA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=qYn3ri6uvIYhCYuhzGAA:9 a=QEXdDO2ut3YA:10 a=C9RNiP1id30A:10 a=AzmulVs9t5cA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from android-68f84e02b5988183.esitwifi.local (S0106788a207e2972.gv.shawcable.net [70.66.154.233]) by spqr.komquats.com (Postfix) with ESMTPSA id C1CC6120E; Mon, 25 Feb 2019 10:09:19 -0800 (PST) Date: Mon, 25 Feb 2019 10:08:59 -0800 User-Agent: K-9 Mail for Android In-Reply-To: <20190225175809.GB47081@spindle.one-eyed-alien.net> References: <201902232114.x1NLE0cH085345@repo.freebsd.org> <20190225175809.GB47081@spindle.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: svn commit: r344487 - in head/sys: conf gnu/gcov To: Brooks Davis ,Matt Macy CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Cy Schubert Message-ID: X-CMAE-Envelope: MS4wfEuqXAt+4SgWR6IeJ/PNp+ihj0c+MRY1sJZTZbjsaE62hzwY7+/VkYsu2Uk1FHfy6Bm723/j5BrvIzR5JnqWvzVRlWkQx3CTSlR66tdhCajxBG+conqC GncGgbMuYVj1xneUEkOAVsZ4xZ1vlBH9aHtseHYWcfMhGwuLEi3rsBRQFlsVnlxv4AQmLMOD2dG2M2rIAblhqhz8fknWFfKkTCQfMmeoEgCwIj9cpF4XMy66 8dD+42UWkNH4/VvfhqK9JGamLdnXrBNs3zNZS+dp4wwh/9WUz7HzQgHAGeu3B1qyKXrTBrMzDbxq7Ux2YyH6FQ== X-Rspamd-Queue-Id: 9BCDC70F4B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.960,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 18:09:31 -0000 On February 25, 2019 9:58:09 AM PST, Brooks Davis wr= ote: >On Sat, Feb 23, 2019 at 09:14:00PM +0000, Matt Macy wrote: >> Author: mmacy >> Date: Sat Feb 23 21:14:00 2019 >> New Revision: 344487 >> URL: https://svnweb=2Efreebsd=2Eorg/changeset/base/344487 >>=20 >> Log: >> gcov support >> =20 >> add gcov support and export results as files in debugfs > >We had a brief discussion of this commit within a subset of core=2E This >addition of GPLv2 code is fine as the code is easily removal to a >module >(per kmoore@) should the day come that we're read to evict all GPL >code=2E >The modest increase in activation energy for that task seems worth it >for the short-term gains of reduced integration cost (this code will >greatly improve our ZFS-on-Linux test coverage=2E) > >Rod rightly points out that we haven't accepted SPDX tags alone as >license statements=2E The standard GPL v2=2E0 boiler plate should be add= ed >to this file along side the tag=2E > >An additional issue is that the a warning tag was not added to >sys/conf/files=2E A warning along the lines of: > > warning "kernel contains GPLv2 licensed GCOV" > >needs to be added=2E > >This commit needed more through review=2E > > >We intend to update our license policy to require core sign off for >new GPL code to ensure we're not adding new, tightly integrated >dependencies, to document that we're doing so knowingly, and >to make sure steps aren't missed=2E The current document is at: >https://www=2Efreebsd=2Eorg/internal/software-license=2Ehtml > >-- Brooks That's a excellent idea=2E I was thinking about suggesting that over the = weekend (actually a committee, but core is better)=2E --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert FreeBSD UNIX: Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E