From owner-freebsd-amd64@freebsd.org Sat Jan 2 19:53:55 2016 Return-Path: Delivered-To: freebsd-amd64@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ACC03A5F4A4 for ; Sat, 2 Jan 2016 19:53:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 838591C1A for ; Sat, 2 Jan 2016 19:53:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u02JrtPr095897 for ; Sat, 2 Jan 2016 19:53:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-amd64@FreeBSD.org Subject: [Bug 205806] [patch] bsdinstall(8): partedit can hang/crash on read/lseek/malloc failures Date: Sat, 02 Jan 2016 19:53:55 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.2-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: will@worrbase.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Mailman-Approved-At: Sat, 02 Jan 2016 21:16:13 +0000 X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2016 19:53:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205806 Bug ID: 205806 Summary: [patch] bsdinstall(8): partedit can hang/crash on read/lseek/malloc failures Product: Base System Version: 10.2-STABLE Hardware: amd64 OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: will@worrbase.com CC: freebsd-amd64@FreeBSD.org Keywords: patch CC: freebsd-amd64@FreeBSD.org Created attachment 164966 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D164966&action= =3Dedit malloc + read in a loop -> mmap The current code for reading in the bootcode from a file has a few problems. https://svnweb.freebsd.org/base/head/usr.sbin/bsdinstall/partedit/gpart_ops= .c?revision=3D285679&view=3Dmarkup#l408 408: if lseek(2) fails, bootsize underflows to SIZE_T_MAX, making the resul= ting allocation dangerous 409: if malloc(3) fails, we end up with a null pointer deref later 413: if read(2) fails, the installer will hang trying to read(2) boot loader code I've replaced this with a call to mmap(2), which will give us what we want,= and also contains more error-handling if something goes wrong. Tested on FreeBSD 10.2-STABLE on amd64. --=20 You are receiving this mail because: You are on the CC list for the bug.=