From owner-svn-src-head@freebsd.org Sat Mar 14 17:40:22 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2106525FC99 for ; Sat, 14 Mar 2020 17:40:22 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48fqb85qBcz3Lvm for ; Sat, 14 Mar 2020 17:40:20 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f43.google.com with SMTP id j16so13549765otl.1 for ; Sat, 14 Mar 2020 10:40:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:cc; bh=ZhUn31aKGtlHPpbmtoHKLFV0FQ9XHog/khUhvcR+F6c=; b=hSgT7QDJPhQN45OKj8kY00ixW2qZ2IkVXXZ6BRwbFiP7gQFPY+1Vq2v++PrDaopLK2 PPwoU/qCO3yhaaQ4ikeUWiHeGxc8ROlvvsyWfdikD1l4KMHYmbOZCcMkx/SqveyNBkmg Tg2a54phb+CN9iL8zJ/d69SAxWH9fOnT1QtxEi4Fwez3ibQ2fepw8QdvqAhxqY/7uUaf eGX++LO4bhasOY5iVydwlS81AlyCXXyCTdoAAUaO4sGetmZIOA8IMRRu3SOJQ3MTCpdS tJc+WO89QInMS+WQI94DdEMgGHZ5PE4x6d0p5dtz3TPEPvyKuBXWhqk00gKQM8gOGQ9n lPbw== X-Gm-Message-State: ANhLgQ2LKOOzNdeXbe3P0MP9jRzM7Bc8tQRmbUctVI+4anOXwZywNh1V gtiIUlgN+l9UmBci7NyWza2p7rPC X-Google-Smtp-Source: ADFU+vuxDyClUWpSZQs72VR4CURn3N/yT3YvCiM+I/acmJ2uGf7J/OgZaCxjnoT6nZ/L7sx9CA8BQQ== X-Received: by 2002:a9d:2a83:: with SMTP id e3mr17353475otb.280.1584207619242; Sat, 14 Mar 2020 10:40:19 -0700 (PDT) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com. [209.85.210.46]) by smtp.gmail.com with ESMTPSA id l29sm9626192ota.55.2020.03.14.10.40.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2020 10:40:18 -0700 (PDT) Received: by mail-ot1-f46.google.com with SMTP id j14so13597443otq.3 for ; Sat, 14 Mar 2020 10:40:18 -0700 (PDT) X-Received: by 2002:a05:6830:110c:: with SMTP id w12mt1001411otq.175.1584207618527; Sat, 14 Mar 2020 10:40:18 -0700 (PDT) MIME-Version: 1.0 References: <202003140557.02E5vMBA097086@repo.freebsd.org> In-Reply-To: <202003140557.02E5vMBA097086@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 14 Mar 2020 10:40:08 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r358988 - head/usr.bin/gzip Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48fqb85qBcz3Lvm X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.210.43 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-1.03 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; RWL_MAILSPIKE_GOOD(0.00)[43.210.85.209.rep.mailspike.net : 127.0.0.18]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; MISSING_TO(2.00)[]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[43.210.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.03)[ip: (-0.46), ipnet: 209.85.128.0/17(-2.97), asn: 15169(-1.65), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Mar 2020 17:40:22 -0000 For additional context, this quiesces (false positive) Coverity CID 1383554. On Fri, Mar 13, 2020 at 10:57 PM Xin LI wrote: > > Author: delphij > Date: Sat Mar 14 05:57:22 2020 > New Revision: 358988 > URL: https://svnweb.freebsd.org/changeset/base/358988 > > Log: > Remove unneeded checks for prelen. > > In order to determine the type of a compressed file, we have to read > in the first four bytes which may also be important for decompression > purposes, to do that we would pass the buffer that we have already > read in, along with the size of it. > > Rename header1 to fourbytes to make that explicit, and remove all > checks for prelen.