From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jul 14 07:31:53 2004 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD3F016A4CE for ; Wed, 14 Jul 2004 07:31:53 +0000 (GMT) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6313F43D39 for ; Wed, 14 Jul 2004 07:31:53 +0000 (GMT) (envelope-from linimon@lonesome.com) Received: by mail.soaustin.net (Postfix, from userid 502) id E3B27148C2; Wed, 14 Jul 2004 02:31:52 -0500 (CDT) Date: Wed, 14 Jul 2004 02:31:52 -0500 (CDT) From: Mark Linimon X-X-Sender: linimon@pancho To: Wesley Shields In-Reply-To: <200407140240.i6E2eFWD093435@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/69024: Please portlint [databases/mysqltcl] X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2004 07:31:53 -0000 On Wed, 14 Jul 2004, Wesley Shields wrote: > On Tue, Jul 13, 2004 at 10:26:00PM -0400, Adam Weinberger wrote: > > > Are you testing these changes or just submitting them? > > Not all of the 20 I just submitted have been tested (mainly because > it would take forever to build quite a few of these) I'm sorry, but from where I sit, untested changes in PRs are worse than useless -- they can lead lead submitters into committing untested changes into the ports collection, which, since Murphy's Law does hold, *will* get them hate-mail immediately. The committers, themselves, will have to test these changes one-by-one, so someone will have to do the work. It would be best if there were no surprises during that step. portlint is a good tool, but it is not a perfect one. It uses heuristics to try to 'guess' what usages that might be bugs in port Makefiles. It is right more often than not, but blindly follwing its advice will quickly lead to broken ports. This isn't just my opinion or me trying to be negative, this is me speaking from experience, and I have the arrows in the back to prove it. Please, please, please, if you want to help us make the ports collection the best it can possibly be, set up a ports jail on a 5.x box and start working through the build errors (see pointyhat.freebsd.org or the summaries on portsmon.firepipe.net) -- that is where our most pressing needs exist. If you have an amd64 machine or a sparc or alpha, so much the better. This will help you to get started on learning where the significant errors lie, and to understand more about whether to take the output of portlint as correct or incorrect. Thanks. mcl