From owner-freebsd-current Mon Sep 18 3:54: 3 2000 Delivered-To: freebsd-current@freebsd.org Received: from mout1.freenet.de (mout1.freenet.de [194.97.50.132]) by hub.freebsd.org (Postfix) with ESMTP id F21EB37B423 for ; Mon, 18 Sep 2000 03:53:52 -0700 (PDT) Received: from [194.97.50.144] (helo=mx1.freenet.de) by mout1.freenet.de with esmtp (Exim 3.16 #20) id 13ayYZ-0008Ms-00; Mon, 18 Sep 2000 12:53:51 +0200 Received: from a3309.pppool.de ([213.6.51.9] helo=Magelan.Leidinger.net) by mx1.freenet.de with esmtp (Exim 3.16 #20) id 13ayYY-00057A-00; Mon, 18 Sep 2000 12:53:50 +0200 Received: from Leidinger.net (netchild@localhost [127.0.0.1]) by Magelan.Leidinger.net (8.11.0/8.11.0) with ESMTP id e8I8xKn01498; Mon, 18 Sep 2000 10:59:21 +0200 (CEST) (envelope-from netchild@Leidinger.net) Message-Id: <200009180859.e8I8xKn01498@Magelan.Leidinger.net> Date: Mon, 18 Sep 2000 10:59:19 +0200 (CEST) From: Alexander Leidinger Subject: Re: patch for openssh To: jdp@polstra.com Cc: current@freebsd.org In-Reply-To: <200009172039.NAA12052@vashon.polstra.com> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 17 Sep, John Polstra wrote: > What is the point of that change? Functionally it makes no difference > at all, since "*auth" is an AuthenticationConnection. It makes the I was a little bit confused at that time. Yes, it's more of a bikeshed decision, IMHO it makes it less difficult to read (you didn't have to search for the type). > code harder to maintain in case the type of "auth" is changed in the > future. This depends on the type of change someone makes. If you didn't change the typedef of "AuthenticationConnection" but the type of "auth", you normaly have to go through the code and ensure every invariant is still valid (I classify this as a major code change, but this is a bikeshed argument too). Bye, Alexander. -- The three Rs of Microsoft support: Retry, Reboot, Reinstall. http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = 7423 F3E6 3A7E B334 A9CC B10A 1F5F 130A A638 6E7E To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message