Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 Feb 2014 14:57:43 GMT
From:      Jean-Sébastien Pédron <dumbbell@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/186979: [PATCH] graphics/darktable: update to 1.4.1
Message-ID:  <201402231457.s1NEvhqG025734@cgiserv.freebsd.org>
Resent-Message-ID: <201402231500.s1NF008E015063@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         186979
>Category:       ports
>Synopsis:       [PATCH] graphics/darktable: update to 1.4.1
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 23 15:00:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Jean-Sébastien Pédron
>Release:        11.0-CURRENT
>Organization:
The FreeBSD Project
>Environment:
FreeBSD magellan.dumbbell.fr 11.0-CURRENT FreeBSD 11.0-CURRENT #0 7e2b0bf(master): Sat Feb 22 18:18:04 CET 2014     root@magellan.dumbbell.fr:/usr/obj/home/dumbbell/Projects/freebsd/src/GIT/sys/GENERIC  amd64
>Description:
The following patch stages and updates graphics/darktable to 1.4.1:
http://people.freebsd.org/~dumbbell/darktable/graphics-darktable-update-141-staging-openmp.b.patch

The following changes were made to options:
- Remove KWALLET option (unused)
- Rename FACEBOOK option to FB_PICASA, because both export features depend on json-glib.
- Add COLORD option (color management)
- Add GRAPHMAGICK option (support GraphicsMagick's image formats)
- Add LUA option (embed Lua to add scripting)
- Add SQUISH option (use libsquish to compress thumbnails)

The patch enables more options by default, because I think it's more sensible for a photographer using binary packages:
- COLORD
- FB_PICASA
- FLICKR
- GEO
- GRAPHMAGICK
- LUA
- NLS
- OPENJPEG
- SQUISH

Regarding the GCC option (enabled by default to provide OpenMP support), USES=compiler:features allows to check if libc++ is the C++ standard library. In this case, devel/libc++ is pulled as a build dependency: this allows GCC to be used even when other libraries (eg. exiv2) were built with Clang.

COLORD adds a LIB_DEPENDS to graphics/colord, but darktable provides it's own libcolord.so internally (statically linked). The comment in src/CMakeLists.txt explains that libcolord.so in many [Linux] distros is linked against Gtk+3.

GRAPHMAGICK adds a LIB_DEPENDS to graphics/GraphicsMagick13: I used library name with version (libGraphicsMagick.so.14), because it doesn't build with graphics/GraphicsMagick. I didn't try with graphics/GraphicsMagick12.

graphics/webp is added as a mandatory option: CMakeLists.txt defines a "USE_WEBP" CMake option, but that option is never used.

patch-cmake_modules_FindFreetype.cmake is removed because the corresponding CMake module is gone.

patch-src-common-imageio_exr.hh is removed because a better fix (one which works for both FreeBSD and Mac OS X) is committed upstream.

pkg-plist's diff is large because I preferred to keep the order of "make makeplist". Future updates will be easier. Otherwise, changes are small.

The patch was tested using advices from StageDir wiki page, except the poudriere/tinderbox step.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402231457.s1NEvhqG025734>