From owner-freebsd-stable@FreeBSD.ORG  Mon Jun  1 16:23:03 2009
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 89DA110656DA;
	Mon,  1 Jun 2009 16:23:03 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 355518FC1C;
	Mon,  1 Jun 2009 16:23:01 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA08334;
	Mon, 01 Jun 2009 19:22:59 +0300 (EEST)
	(envelope-from avg@freebsd.org)
Message-ID: <4A240063.207@freebsd.org>
Date: Mon, 01 Jun 2009 19:22:59 +0300
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Thunderbird 2.0.0.21 (X11/20090406)
MIME-Version: 1.0
To: Henri Hennebert <hlh@restart.be>
References: <3c1674c90905201643m540c8b1v8a8bd88f071c233d@mail.gmail.com>		<4A1D0F2B.4030006@restart.be>		<ed91d4a80905271104g2a824d0fna004d1c4f3126c67@mail.gmail.com>	<3c1674c90905280052q281f6172j2409fe2d64db6914@mail.gmail.com>
	<4A1E90F7.2000000@restart.be> <4A1E97D8.4080901@icyb.net.ua>
	<4A1FD687.5070502@freebsd.org> <4A23EEC8.2040208@freebsd.org>
	<4A23FDE5.1040101@restart.be>
In-Reply-To: <4A23FDE5.1040101@restart.be>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org,
	Kip Macy <kmacy@freebsd.org>, John Baldwin <jhb@freebsd.org>
Subject: Re: libzpool assert vs libc assert
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jun 2009 16:23:04 -0000

on 01/06/2009 19:12 Henri Hennebert said the following:
> Andriy Gapon wrote:
>> I propose the following patch for this issue.
>> It fixes mismatch between __assert extern declaration in zfs code and
>> actual
>> signature in libc code.
>> I also took liberty of dropping __STDC__ and __STDC_VERSION__ checks.
>> I think that
>> those checks are not needed with compilers that can be used to compile
>> FreeBSD.
>> Besides, both branches of __STDC_VERSION__ check were exactly the same.
>>
>> Henri,
>>
>> if you still experience that crash of zpool command, could you please
>> try the
>> patch and see if you have a nicer assert message and stacktrace now?
>> Sorry, that this is still not a fix for the real issue.
>>
> Here is the new bt after the patch

Henri,

thank you very much for testing!
It look like the patch did its job.

P.S. hopefully someone is looking into the cause of the assertion.

> Assertion failed: (mp->m_owner == NULL), function zmutex_destroy, file
> /usr/src/cddl/lib/libzpool/../../../cddl/contrib/opensolaris/lib/libzpool/common/kernel.c,
> line 112.
> 
> Program received signal SIGABRT, Aborted.
> [Switching to Thread 0x8018020b0 (LWP 100178)]
> 0x000000080121fadc in thr_kill () from /lib/libc.so.7
> (gdb) bt
> #0  0x000000080121fadc in thr_kill () from /lib/libc.so.7
> #1  0x00000008012af06b in abort () from /lib/libc.so.7
> #2  0x0000000801296fe5 in __assert () from /lib/libc.so.7
> #3  0x0000000800fef42e in zmutex_destroy (mp=0x8018b2cc0) at

-- 
Andriy Gapon