Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Jul 2013 19:16:05 +0200
From:      Gabor Kovesdan <gabor.kovesdan@gmail.com>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r323538 - in head/x11-fonts: . andika andika/files
Message-ID:  <51F00BD5.5030108@FreeBSD.org>
In-Reply-To: <20130724170826.GA10662@FreeBSD.org>
References:  <201307231610.r6NGAAwC070825@svn.freebsd.org> <20130724170826.GA10662@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2013.07.24. 19:08, Alexey Dokuchaev wrote:
> On Tue, Jul 23, 2013 at 04:10:10PM +0000, Gabor Kovesdan wrote:
>> >New Revision: 323538
>> >URL:http://svnweb.freebsd.org/changeset/ports/323538
>> >
>> >@@ -0,0 +1,50 @@
>> >+# $FreeBSD$
>> >+
>> >+PORTNAME=	Andika
> Any reason for uppercase-starting PORTNAME (and thus PKGNAME)?
>
>> >+do-configure:
>> >+	${DO_NADA}
> If port does not use any of two *_CONFIGURE knobs, this probably is not
> needed; and even if it is, it should be spelled as @${DO_NADA}.
>
>> >+do-install:
>> >+	${ECHO_MSG}
>> >+	${CAT} ${PKGMESSAGE}
>> >+	${ECHO_MSG}
> We usually display pkg-message as the last step (after all other functional
> commands).
>
>> >+	${MKDIR} ${FONTROOTDIR}/${FONTDIR}
>> >+	${INSTALL_DATA} ${WRKSRC}/*.ttf ${FONTROOTDIR}/${FONTDIR}
>> >+.if ${PORT_OPTIONS:MDOCS}
>> >+	${MKDIR} ${DOCSDIR}
>> >+	${INSTALL_DATA} ${DOCSLIST:S,^,${WRKSRC}/,} ${DOCSDIR}
>> >+.endif
1) and 3) was done as done by x11-fonts/gentium-plus since this font 
comes from the same vendor.

2) It implicitly uses one of them (probably comes from XORG_CAT).

Gabor



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51F00BD5.5030108>