Date: Wed, 28 Feb 2007 10:13:59 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb umass.c Message-ID: <43468.1172657639@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 28 Feb 2007 03:10:00 MST." <20070228.031000.1649769988.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20070228.031000.1649769988.imp@bsdimp.com>, "M. Warner Losh" writes : >: > Create a new quirk READ_CAPACITY_OFFBY1 >: >: A better idea would be to have scsi_da.c try to read the >: last sector and chop it if it fails. > >Why is that a better idea? Because it will work automatically and not rely on us preventively adding the bogus devices to the kernel. Trivially testable quicks shouldn't have to be compiled into static lists. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43468.1172657639>