From owner-cvs-src@FreeBSD.ORG Sun Oct 10 21:36:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F5D716A4CE; Sun, 10 Oct 2004 21:36:24 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4AC7943D48; Sun, 10 Oct 2004 21:36:24 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9ALaA9A006949; Sun, 10 Oct 2004 14:36:10 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9ALa6ob006948; Sun, 10 Oct 2004 14:36:06 -0700 (PDT) (envelope-from obrien) Date: Sun, 10 Oct 2004 14:36:06 -0700 From: "David O'Brien" To: "M. Warner Losh" Message-ID: <20041010213606.GA6835@dragon.nuxi.com> References: <200410090831.i998VLD6076466@repoman.freebsd.org> <20041009.210103.115654872.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041009.210103.115654872.imp@bsdimp.com> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa pbio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Oct 2004 21:36:24 -0000 On Sat, Oct 09, 2004 at 09:01:03PM -0600, M. Warner Losh wrote: > In message: <200410090831.i998VLD6076466@repoman.freebsd.org> > "David E. O'Brien" writes: > : obrien 2004-10-09 08:31:21 UTC > : > : FreeBSD src repository > : > : Modified files: > : sys/i386/isa pbio.c > : Log: > : style(9) > > Thanks for obsoleting the busspace changes that I was working on. I assume this said sarcastically... I think this is a little harsh. I wish you had mentioned publicly that you were going to busspace it. In the thread when it was committed to HEAD and noticed this driver used depreciated interfaces, it was said it shouldn't be too hard to use proper interfaces -- but I didn't see a commitment to do the work. I wasn't sure what a 'pbio' driver was so I went to read the code and noticed it had inconsistent style (and had some style(9) compliancy issues). Thus I fixed it. As I said I think it is a little harsh to take the position your work is killed. You can (1) copy your sys/i386/isa/.#pbio.c.1.1 to pbio.c and continue your work, sending me your finished file and I'll re-style(9) it before committing. (2) commit your busspace'ification to RELENG_4 and I'll cvs merge it from the branch. -- -- David (obrien@FreeBSD.org)