From owner-freebsd-bugs@FreeBSD.ORG Thu May 1 08:30:00 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B5AA318C for ; Thu, 1 May 2014 08:30:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 771491D3F for ; Thu, 1 May 2014 08:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s418U0BO036025 for ; Thu, 1 May 2014 08:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s418U0cv036023; Thu, 1 May 2014 08:30:00 GMT (envelope-from gnats) Resent-Date: Thu, 1 May 2014 08:30:00 GMT Resent-Message-Id: <201405010830.s418U0cv036023@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Matthew D.Fuller" Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CFD3C116 for ; Thu, 1 May 2014 08:22:50 +0000 (UTC) Received: from thyme.infocus-llc.com (server.infocus-llc.com [206.156.254.44]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "*.infocus-llc.com", Issuer "*.infocus-llc.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A9C4C1CFB for ; Thu, 1 May 2014 08:22:50 +0000 (UTC) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id 8C5C837B513 for ; Thu, 1 May 2014 03:22:49 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3gK8jP19jQz2T7; Thu, 1 May 2014 03:22:49 -0500 (CDT) Message-Id: <3gK8jP19jQz2T7@draco.over-yonder.net> Date: Thu, 1 May 2014 03:22:49 -0500 (CDT) From: "Matthew D.Fuller" To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: kern/189170: [PATCH] [newcons] Implement KDMKTONE ioctl X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: "Matthew D.Fuller" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 May 2014 08:30:00 -0000 >Number: 189170 >Category: kern >Synopsis: [PATCH] [newcons] Implement KDMKTONE ioctl >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu May 01 08:30:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Matthew D. Fuller >Release: FreeBSD 9.1-STABLE amd64 >Organization: >Environment: System: FreeBSD draco.over-yonder.net 9.1-STABLE FreeBSD 9.1-STABLE #0 r251584: Sun Jun 9 14:23:33 CDT 2013 root@draco.over-yonder.net:/usr/obj/usr/src/sys/DRACO amd64 >Description: newcons has KDMKTONE ioctl stubbed out, which means that things that try to sound the bell (like X) wind up doing nothing. And working with X is a big part of the push for newcons, so it should do so :) >How-To-Repeat: >Fix: Index: sys/dev/vt/vt_core.c =================================================================== --- sys/dev/vt/vt_core.c (revision 264991) +++ sys/dev/vt/vt_core.c (working copy) @@ -1636,7 +1636,11 @@ #endif return (0); case KDMKTONE: /* sound the bell */ - /* TODO */ + if(*(int*)data) + sysbeep(1193182 / ((*(int*)data)&0xffff), + (((*(int*)data)>>16)&0xffff)*hz/1000); + else + vtterm_bell(tm); return (0); case KIOCSOUND: /* make tone (*data) hz */ /* TODO */ >Release-Note: >Audit-Trail: >Unformatted: