From owner-freebsd-testing@FreeBSD.ORG  Sun Mar  2 21:23:25 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 25E0CA01
 for <freebsd-testing@freebsd.org>; Sun,  2 Mar 2014 21:23:25 +0000 (UTC)
Received: from mail-qc0-f178.google.com (mail-qc0-f178.google.com
 [209.85.216.178])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D3EA91A7B
 for <freebsd-testing@freebsd.org>; Sun,  2 Mar 2014 21:23:24 +0000 (UTC)
Received: by mail-qc0-f178.google.com with SMTP id i8so2975795qcq.37
 for <freebsd-testing@freebsd.org>; Sun, 02 Mar 2014 13:23:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc:content-type;
 bh=0zSrlUGQ/pW3WcO50tiGjP1ik3f5pzPMijXMT7QhB7E=;
 b=Wgr9CxcQi+3KhMTn7DUpDJCkuVYNvwWyU/1vUYWJcEnMwQiEcfdnU4FcFjzy0nAJfb
 PhJKVc9u9KMFd5cQVY98yPwoLr7grOIi7qsGqdHXNVmoq14cII/10x2jcDpXN4pp7VyT
 e9Fu4OIoZ1dt6nHv6djIipdrLt/MDDzWfjEB6+hZ1dWVlZw2Is5zBiqBwr5FRGp+ASWn
 QrE4fG0DIy/woTSPZN74mZVGOd2o65dIEzrjaGsJCyvIBt0Twp4RxFc2hYgOOje5V+i+
 DaTdt07v/nkZ9mT1QrWUxGh3Lz0OE9a44MS8iKTFk9cj3tsZ4iASCQfGgnGuUcCcAav7
 aVZQ==
X-Gm-Message-State: ALoCoQmmSmDdko3oOb39IPiphcWBCwTsnLyPPBADFCHaHYZyXc2FIiiaPBj9+uwozdzpAsn6orZp
X-Received: by 10.229.139.199 with SMTP id f7mr19219732qcu.2.1393795398261;
 Sun, 02 Mar 2014 13:23:18 -0800 (PST)
MIME-Version: 1.0
Sender: jmmv@meroh.net
Received: by 10.96.83.102 with HTTP; Sun, 2 Mar 2014 13:22:58 -0800 (PST)
X-Originating-IP: [108.176.158.82]
In-Reply-To: <4A25ADF9-3714-4006-ACB6-F8C745CB38AE@gmail.com>
References: <6079AD8F-5EBB-431C-A06B-9B51E2729F5A@gmail.com>
 <B90AA730-B7B8-4F1A-9D07-67861C9A6401@meroh.net>
 <FA467521-BB53-47C0-BAE1-8BCAE29F922F@gmail.com>
 <CADyfeQXG6KGwgT1X90Ymr+FYnwL74H_G2zBvkgdzEhPospNM8A@mail.gmail.com>
 <4A25ADF9-3714-4006-ACB6-F8C745CB38AE@gmail.com>
From: Julio Merino <jmmv@freebsd.org>
Date: Sun, 2 Mar 2014 16:22:58 -0500
X-Google-Sender-Auth: VkifBH0jK1PzQLIhyEBT2jgewno
Message-ID: <CAFY7cWBHaftY=LOen=_gescMkoyCoKU69HRyqOfW10YAZ2OzuQ@mail.gmail.com>
Subject: Re: [PATCH v2] convert bin/date over to ATF
To: Garrett Cooper <yaneurabeya@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>,
 Giorgos Keramidas <keramida@freebsd.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Mar 2014 21:23:25 -0000

On Mon, Jan 27, 2014 at 5:03 AM, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>         The attached patch incorporates the input from Julio for converting bin/date/tests over to ATF.

Apologies for the delay here as well...

Pretty much all style nits:

* This file is full of boilerplate and it's really hard to actually
see the tests. I think this would benefit from a simple helper
function that calls atf_test_case and evals the tiny body() with the
call to check.

* I'd get rid of the descr definitions; they provide no value.

* I'd also get rid of all the horizontal dividing lines.  If you make
the test case definitions compact, they just serve to increase the
file length.

* Remove the TZ and LC_ALL overrides.  This is a given within ATF.

* Why "format_string_functional_test"?  I'd just call it "format_string_test".

* I don't think the # vim trailing line belongs in the tree.