Date: Fri, 06 May 2022 06:45:58 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: =?US-ASCII?Q?Re=3A_git=3A_dfae67d10c3f_-_main_-_bsd=2Eport=2Emk=3A_Use_?= =?US-ASCII?Q?zstandard_as_default_compression_for_FreeBSD_14+?= Message-ID: <FC443D93-44AB-4A30-9C08-81A22AF56ADB@FreeBSD.org> In-Reply-To: <de4233f9-1f21-c515-4b64-6f27e99d8721@FreeBSD.org> References: <202205031212.243CCusl028589@gitrepo.freebsd.org> <6ae7eeda-b0af-32d3-c9b8-379813a3f775@FreeBSD.org> <de4233f9-1f21-c515-4b64-6f27e99d8721@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Le 6 mai 2022 02:07:51 GMT+02:00, Bryan Drewery <bdrewery@FreeBSD=2Eorg> a= =C3=A9crit=C2=A0: >On 5/5/2022 5:06 PM, Bryan Drewery wrote: >> On 5/3/2022 5:12 AM, Baptiste Daroussin wrote: >>> The branch main has been updated by bapt: >>>=20 >>> URL: https://cgit=2EFreeBSD=2Eorg/ports/commit/?id=3Ddfae67d10c3f2b6db= de7d6e3280455cd87f9f15c=20 >>>=20 >>> commit dfae67d10c3f2b6dbde7d6e3280455cd87f9f15c >>> Author:=C2=A0=C2=A0=C2=A0=C2=A0 Baptiste Daroussin <bapt@FreeBSD=2Eorg= > >>> AuthorDate: 2022-04-29 14:03:13 +0000 >>> Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Baptiste Daroussin <bapt@FreeBSD=2Eorg= > >>> CommitDate: 2022-05-03 12:04:26 +0000 >>>=20 >>> =C2=A0=C2=A0=C2=A0=C2=A0 bsd=2Eport=2Emk: Use zstandard as default com= pression for FreeBSD 14+ >>> =C2=A0=C2=A0=C2=A0=C2=A0 The packages are switched from XZ to ZSTD com= pression, the compression level >>> =C2=A0=C2=A0=C2=A0=C2=A0 is set at the maximum possible because it cre= ates packages which are closed >>> =C2=A0=C2=A0=C2=A0=C2=A0 in size between XZ and ZSTD, the compression = time is close as well, >>> =C2=A0=C2=A0=C2=A0=C2=A0 but decompression time is way bigger=2E >>> =C2=A0=C2=A0=C2=A0=C2=A0 Exp-run:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 antoine >>> =C2=A0=C2=A0=C2=A0=C2=A0 Differential revision:=C2=A0 https://reviews= =2Efreebsd=2Eorg/D35095 >>> --- >>> =C2=A0 Mk/bsd=2Eport=2Emk | 8 ++++---- >>> =C2=A0 1 file changed, 4 insertions(+), 4 deletions(-) >>>=20 >>=20 >> Please can the symlink generation for this be disabled? It causes probl= ems for Poudriere=2E Everything was stable with the =2Etxz transition and n= ow we have =2Etzst symlinks being created that Poudriere does not expect=2E= It does not make sense to have transition symlinks for a new format=2E > >Last time we discussed this I believe you thought only ports-mgmt/pkg its= elf had a symlink, but no, every package built gets the symlink=2E > No there is 2 things=2E There is the ports tree which creates symlinks onl= y for backward compatible bootstrap and there is pkg creating some other sy= mlinks for another backward compatibility=2E While the first needs to remain a bit, the second is not necessary anymore= at all Bapt >>=20 >>> diff --git a/Mk/bsd=2Eport=2Emk b/Mk/bsd=2Eport=2Emk >>> index be720a035d87=2E=2Ec2760881ac04 100644 >>> --- a/Mk/bsd=2Eport=2Emk >>> +++ b/Mk/bsd=2Eport=2Emk >>> @@ -2214,11 +2214,11 @@ PKG_SUFX=3D=C2=A0=C2=A0=C2=A0 =2Epkg >>> =C2=A0 =2E=C2=A0=C2=A0=C2=A0 if defined(PKG_NOCOMPRESS) >>> =C2=A0 PKG_COMPRESSION_FORMAT?=3D=C2=A0=C2=A0=C2=A0 tar >>> =C2=A0 =2E=C2=A0=C2=A0=C2=A0 else >>> -#=2Eif ${OSVERSION} > 1400000 >>> -#PKG_COMPRESSION_FORMAT?=3D=C2=A0=C2=A0=C2=A0 tzst >>> -#=2Eelse >>> +=2Eif ${OSVERSION} > 1400000 >>> +PKG_COMPRESSION_FORMAT?=3D=C2=A0=C2=A0=C2=A0 tzst >>> +=2Eelse >>> =C2=A0 PKG_COMPRESSION_FORMAT?=3D=C2=A0=C2=A0=C2=A0 txz >>> -#=2Eendif >>> +=2Eendif >>> =C2=A0 =2E=C2=A0=C2=A0=C2=A0 endif >>> =C2=A0 # where pkg(8) stores its data >>=20 >>=20 > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FC443D93-44AB-4A30-9C08-81A22AF56ADB>