From owner-svn-ports-all@FreeBSD.ORG Tue May 19 21:24:04 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7B69D7B1; Tue, 19 May 2015 21:24:04 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CEC0017B4; Tue, 19 May 2015 21:24:03 +0000 (UTC) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 7fc8c832; TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO; Tue, 19 May 2015 15:23:56 -0600 (MDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: svn commit: r386737 - in head/security: . tmux-cssh From: Adam Weinberger In-Reply-To: <38D41B521FF4590990C78FD2@atuin.in.mat.cc> Date: Tue, 19 May 2015 15:23:54 -0600 Cc: Baptiste Daroussin , "Vanilla I. Shu" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201505190333.t4J3X7BS037914@svn.freebsd.org> <20150519160457.GD52236@ivaldir.etoilebsd.net> <38D41B521FF4590990C78FD2@atuin.in.mat.cc> To: Mathieu Arnold X-Mailer: Apple Mail (2.2098) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2015 21:24:04 -0000 > On 19 May, 2015, at 15:15, Mathieu Arnold wrote: >=20 >=20 >=20 > +--On 19 mai 2015 10:15:36 -0600 Adam Weinberger = wrote: > |> On 19 May, 2015, at 10:04, Baptiste Daroussin = wrote: > |>=20 > |> On Tue, May 19, 2015 at 03:33:07AM +0000, Vanilla I. Shu wrote: > |>> Author: vanilla > |>> Date: Tue May 19 03:33:06 2015 > |>> New Revision: 386737 > |>> URL: https://svnweb.freebsd.org/changeset/ports/386737 > |>>=20 > |>>=20 > |>> +RUN_DEPENDS=3D ${LOCALBASE}/bin/tmux:${PORTSDIR}/sysutils/tmux > |> The dependency is wrong it should be tmux:${PORTSDIR}/sysutils/tmux > |>=20 > |> Best regards, > |> Bapt > |=20 > | I've seen that construct popping up a lot lately. I suspect that the > | problem is that > | = https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefi > | le-depend.html lists ${LOCALBASE}/.../ as the first example. > |=20 > | Perhaps it would be helpful to add something saying "Only include an > | absolute path if the binary is outside of $PATH, or if the binary = also > | exists in base and you specifically want the ports tree version." >=20 > There's a note afterwards saying it, but you're right, there should be = an > example with only a binary in the path first. It says to use full path when it's not in $PATH. What it doesn't say is = to use full path ONLY when it's not in $PATH :-) # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org