From nobody Thu Mar 26 14:53:37 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fhRcH6W5Gz6RctK for ; Thu, 26 Mar 2026 14:53:51 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fhRcG6tNcz3k9P for ; Thu, 26 Mar 2026 14:53:50 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; arc=pass ("google.com:s=arc-20240605:i=1"); dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=asomers@gmail.com Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-66971ccfcabso1423792a12.3 for ; Thu, 26 Mar 2026 07:53:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774536829; cv=none; d=google.com; s=arc-20240605; b=GURBbof04t883F1NX7WJ7VQD8aEdU4kAzGQy9loSFj6D5kE33Jnu2XlOCLlaTLX+Y7 sgqHgh/0J024FdEUI4/we9xDnZtSFprHsZ3nzoijzUYxqow0CWJG1feXs/C8uW9rhjGY sGwrm/MizxCWbRfjHw/KyPWTsp/bHq1aGCsgkDGWPQrg7VjxBpexAqfAAFlGzBtXgsR8 ArQzPp1BgHWc12vfSkS5gL5wq9Lcfkrv6X2vVgJwVGT4aDQa3C3EG9pIpgfl5WYolgEN /ZHnft89wpodtiLBV2H7GwwEdtYkiN1U46Dpzc5smCKePIAdoFyrsZS0OqNdOkWdlzim d6Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=4f1bZFMh/gy8owIf9XIt06cs28oDgDe6Sxs19qE7l64=; fh=se3WMX5INUWfOwU6yGMXgdQ44hQYUFfrMeenPO+nrOg=; b=OWrZi93ITbtZRxsXPmrKJaYmbQ5PKVG2+Co7/xwOkmbdEVVXNxUfH6p6jweYQv9yBe mgZQsVIDldwHU3dZA+A0Kei1spZ6+xDHu+OrdiF8HivgagYje+PLz+hmKIRuVRQSIvfs jJxMxHEqXq15UucBlR5Pk4Xa80Ougno897ErTnBeGqR4xcIVM+tSdLdBroMk3GxaDcNF QMAHQXMnfcfSxYni7J59MAbZ4jxXmzae+cmKkyzpht154BcV1oiiNBrIYH5Q6KlHVyXe EqA0f3awz102P+qJIHwy8aVHyCFfh6YYUWUSepPYLb5E4p7xtODhUqqY8hK/710gHcMq N0Bw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774536829; x=1775141629; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4f1bZFMh/gy8owIf9XIt06cs28oDgDe6Sxs19qE7l64=; b=fIQ7GroIZijkERKC/hoybAS58w6wIhhwhcqNetRECCzv0VEC47EgXaNLVApfK1sVoo 26ySJW+bTXFb9eT6Wv9mi6niXj6fMHVrV0p492gR4xv2ac+3wPxBBQ37uTzkyFXqnGiA kZhKHCEkpdCJju604cHFHY+Bxt+wCPPa91mBLeXeG7GTPuS72l5xCfqo9Ll2/xa6MCcR 4xSCW3UNeIiW56UMo7dL6i4pCYmnRafqQtJRRf4gdiUJSUvNGCZaDMTJWB8spF1Nmzrz w+j9japvumBB+PBrmTGkGCeWWWs6z9cajWWGsHBR5Mi8pPqggKZ8wk07MskniecCUAOP so7A== X-Forwarded-Encrypted: i=1; AJvYcCW3Og5etvzx/7xp1dU3K1VZFbylEo8IVI0p0hZ4r6O7POV0SroVUD8FAPW2/a/JsUO/zs67rg98XsUz/U7rU732jvsD@freebsd.org X-Gm-Message-State: AOJu0Yx/QKutpjga/v0KnVhYdsKm47R/dqUf74iX9xOQK3bEQ4vKm0za oeg8I3BBHnaHCPmaO3gz1Emm6ngneMdRpXWhPZLspopbv2jbddqJHazA+NShDHDJP9Ue9CRlTBe F42W7L7VLdK0V01I7lkrlhUp+UMo79auseA== X-Gm-Gg: ATEYQzySUezNLzFDF4VmxoQlP9cUo3AfwyBED/Dkxt4ku4Mam+ei21tV5zB6roCcblI YzXD6r4nGnpin+L0quBeXgyOhV5meZHqI0PkPugTbt8fb9c+oEk/mUhjYuNAz6ALK12uDzwKAbE PxjYK0piVsQjZJqLYBMrdUuyvePscdH7S/7XobXj0+yhd/XZH/Gjk4xIue+MpqM11IfAZY2Al0I XiGSdg8vIGeFu745zUna2eyvYLbOpHMx6LTW5wGQ20rkTolHiUNcj16Ene/k1QKXmaGTDUMU74K 0YyTE3AeChDqVp5zNioGPNX9I5I+LWXYpsCxH0kfTonS+T8Lhiq9VhqwUAOx2uv8RufhGjGhsQe TdxI= X-Received: by 2002:a05:6402:348a:b0:668:502d:80c6 with SMTP id 4fb4d7f45d1cf-66a826e1cdfmr4637503a12.25.1774536829233; Thu, 26 Mar 2026 07:53:49 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202510221659.59MGxpsK054765@gitrepo.freebsd.org> In-Reply-To: <202510221659.59MGxpsK054765@gitrepo.freebsd.org> From: Alan Somers Date: Thu, 26 Mar 2026 08:53:37 -0600 X-Gm-Features: AQROBzCwKx1vn0jU2aoi85WuZ0-pTQM42HYyUyHG-CpYfhX0EsAgsfSdl2CZmUU Message-ID: Subject: Re: git: 62aef3f73f38 - main - vfs_cluster.c: Do not propagate VOP_BMAP errors to the caller To: Gleb Popov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.98 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; ARC_ALLOW(-1.00)[google.com:s=arc-20240605:i=1]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; NEURAL_HAM_SHORT(-0.08)[-0.084]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MIME_TRACE(0.00)[0:+]; FREEFALL_USER(0.00)[asomers]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_ONE(0.00)[1]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.44:from]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; R_DKIM_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.44:from]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4fhRcG6tNcz3k9P X-Spamd-Bar: -- On Wed, Oct 22, 2025 at 11:00=E2=80=AFAM Gleb Popov wr= ote: > > The branch main has been updated by arrowd: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D62aef3f73f38db9fb68bffc12c= c8900fecd58f0e > > commit 62aef3f73f38db9fb68bffc12cc8900fecd58f0e > Author: Gleb Popov > AuthorDate: 2025-07-11 07:42:09 +0000 > Commit: Gleb Popov > CommitDate: 2025-10-22 16:59:21 +0000 > > vfs_cluster.c: Do not propagate VOP_BMAP errors to the caller > > The code that makes this VOP_BMAP call tries to perform a read-ahead = I/O > operation. Failing to do that for any reason isn't fatal for `cluster= _read()`, > because we still can return some data to the caller. This change is c= onsistent > with other places within `cluster_read()`, where error returned by VO= P_BMAP is > not returned to the caller - see the `if (nblks > 1)` block above the= changed > lines and `if (reqbp)` at the end of the function. > > PR: 264196 > Approved by: markj, kib > Differential Revision: https://reviews.freebsd.org/D51254 Shall we MFC this change? I think it affects 15.0-RELEASE.