From owner-freebsd-net@FreeBSD.ORG Mon Jul 16 20:40:16 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 392F910656AB for ; Mon, 16 Jul 2012 20:40:16 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id A19898FC18 for ; Mon, 16 Jul 2012 20:40:15 +0000 (UTC) Received: by weyx56 with SMTP id x56so5614445wey.13 for ; Mon, 16 Jul 2012 13:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=zL4KplPMtTkRLuLgJZuHoOlFW2dnJhdrPd9MJ0QL/F0=; b=aefOofwaipnQVoX1bEHP5K1eGJEJMChLQ6cv6683AHc1SIv4rFxds2wbItnaHkvmal z1nhb10DzAQ4GpIa6i8dqX63E2oqXNvT3q40pbqpKuJPftY6dylykBHWDvj5+EWc9AUW 5aekpmZuL+cP/Dz4EaFIOLmxfu+O7S31JExNZTXPKgOSmK0KYtjf01pnfgyhlzW6UoiI v0xDSZJY8IqYYpVI1OVOpLqVco8BNSpB+hyh6X8BK9qacwMSUhL7REloe+PIJeKgzP1y g+fElvS/v6hapeEN4tGmue/egDjw4ZHe2ttNxn3NCZyvh5iH7Bl8+V1/yfAAJRylXM0I YzqA== MIME-Version: 1.0 Received: by 10.216.74.21 with SMTP id w21mr1032898wed.77.1342471214667; Mon, 16 Jul 2012 13:40:14 -0700 (PDT) Received: by 10.180.146.130 with HTTP; Mon, 16 Jul 2012 13:40:14 -0700 (PDT) In-Reply-To: <50047207.8060004@networx.ch> References: <3AC8C112-A80B-4D8F-89DA-DA38E4AB524F@grep.my> <0FF9D20C-4D88-484F-AEB9-E6F10094E018@grep.my> <50047207.8060004@networx.ch> Date: Mon, 16 Jul 2012 13:40:14 -0700 Message-ID: From: Jack Vogel To: Andre Oppermann Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-net@freebsd.org, Ihsan Junaidi Ibrahim Subject: Re: Enable LRO by default on igb X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2012 20:40:16 -0000 Right, I was aware of the fix, so is there enough interest in this to have me get it enabled in the driver before 9.1 releases, its a couple lines of change and I'm fine with making it ?? Jack On Mon, Jul 16, 2012 at 12:56 PM, Andre Oppermann wrote: > On 13.07.2012 02:21, Ihsan Junaidi Ibrahim wrote: > >> I did a quick file download test on the LRO-enabled device (forwarding is >> turned on) and there's >> no perceive drop-off in forwarding performance. >> > > LRO must not be active on any interface when forwarding is enabled. > This has been fixed by bz@ in current and stable/9 within the LRO > code and is automatic. > > The only remaining unhandled case is hardware-LRO where the driver > must tell the hardware to stop doing it. Eventually we need an > eventhandler for that and hardware-LRO cards have to register with > it to get informed on changes there. > > -- > Andre > > > The test is very unscientific (over the Internet) as I don't have access >> to a local test bed >> where I can do more in-depth testing. >> >> Sysctl LRO stats gave me these: dev.igb.0.queue0.lro_queued: 53 >> dev.igb.0.queue0.lro_flushed: 53 >> dev.igb.0.queue1.lro_queued: 121 dev.igb.0.queue1.lro_flushed: 120 >> dev.igb.0.queue2.lro_queued: >> 14895 dev.igb.0.queue2.lro_flushed: 8200 dev.igb.0.queue3.lro_queued: 77 >> dev.igb.0.queue3.lro_flushed: 76 >> >> Just curious on why flushed and queued numbers did not seem to match. >> >> ihsan >> >> On Jul 8, 2012, at 12:26 AM, Jack Vogel wrote: >> >> Because of problems with forwarding when it was turned on, however this >>> has recently been fixed >>> supposedly, if someone using the driver in an environment with >>> forwarding could verify that >>> there is no problem with it enabled I'd be happy to change it to be on >>> by default. >>> >>> Jack >>> >>> >>> On Sat, Jul 7, 2012 at 9:01 AM, Ihsan Junaidi Ibrahim >>> wrote: >>> >>> Hi folks, >>>> >>>> Just curious is there a reason why LRO isn't turned on by default for >>>> igb(4) like for other >>>> capabilities? >>>> >>>> I have a couple of 82575EB igb devices and LRO had to be turned on >>>> manually. >>>> >>>> Thanks._______________________**________________________ >>>> freebsd-net@freebsd.org mailing list >>>> http://lists.freebsd.org/**mailman/listinfo/freebsd-netTo unsubscribe, send any mail to >>>> "freebsd-net-unsubscribe@**freebsd.org >>>> " >>>> >>>> ______________________________**_________________ >>> freebsd-net@freebsd.org mailing list >>> http://lists.freebsd.org/**mailman/listinfo/freebsd-netTo unsubscribe, send any mail to >>> "freebsd-net-unsubscribe@**freebsd.org >>> " >>> >> >> ______________________________**_________________ freebsd-net@freebsd.orgmailing list >> http://lists.freebsd.org/**mailman/listinfo/freebsd-netTo unsubscribe, send any mail to >> "freebsd-net-unsubscribe@**freebsd.org >> " >> >> >> > >