From owner-svn-src-head@freebsd.org Fri Feb 28 21:16:09 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 03C3F246199; Fri, 28 Feb 2020 21:16:09 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48Tj545vN8z3yY2; Fri, 28 Feb 2020 21:16:08 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id D606E3C0199; Fri, 28 Feb 2020 21:16:01 +0000 (UTC) Date: Fri, 28 Feb 2020 21:16:01 +0000 From: Brooks Davis To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358416 - head/sys/sys Message-ID: <20200228211601.GC48231@spindle.one-eyed-alien.net> References: <202002280102.01S1223Q036983@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lCAWRPmW1mITcIfM" Content-Disposition: inline In-Reply-To: <202002280102.01S1223Q036983@repo.freebsd.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 48Tj545vN8z3yY2 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 21:16:09 -0000 --lCAWRPmW1mITcIfM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 28, 2020 at 01:02:02AM +0000, Warner Losh wrote: > Author: imp > Date: Fri Feb 28 01:02:01 2020 > New Revision: 358416 > URL: https://svnweb.freebsd.org/changeset/base/358416 >=20 > Log: > Remove duplicated ATA_CHECK_POWER_MODE >=20 > Modified: > head/sys/sys/ata.h >=20 > Modified: head/sys/sys/ata.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/sys/ata.h Fri Feb 28 00:42:27 2020 (r358415) > +++ head/sys/sys/ata.h Fri Feb 28 01:02:01 2020 (r358416) > @@ -507,7 +507,6 @@ struct ata_params { > #define ATA_SF_DIS_SRVIRQ 0xde /* disable service inter= rupt */ > #define ATA_SF_LPSAERC 0x62 /* Long Phys Sect Align ErrRep*/ > #define ATA_SF_DSN 0x63 /* Device Stats Notification */ > -#define ATA_CHECK_POWER_MODE 0xe5 /* Check Power Mode */ > #define ATA_SECURITY_SET_PASSWORD 0xf1 /* set drive password */ > #define ATA_SECURITY_UNLOCK 0xf2 /* unlock drive using pa= sswd */ > #define ATA_SECURITY_ERASE_PREPARE 0xf3 /* prepare to erase driv= e */ >=20 I know that's not that you were working on, but that's a remarkable collection of whitespace decisions in the remaining lines. -- Brooks --lCAWRPmW1mITcIfM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJeWYMQAAoJEKzQXbSebgfAmtAH/jJ3qHhgihOuOQvcwFkfVWD4 GpUfA/Upa3Cn4AkT7iND8NcssBShz5FvF1P/V1A68tu64fDOMk8rxHiBMUVZY9jh NOTXtbj0wr0YZKK0RobSV03EV8ydSvW4bPmTdfpQArOmAAbPKyrW2ez7NaC+wJFC knAay+97BJRzwcfqVpPH1Z+wP6HXyphvMVTguFwU4rROG5+MbOg2Hf34ZwOurQgR JtFjW2seHQkQzod8icuMiqI3CSGwYvfUo03WuA1iaMedoq6SM2c9IrDKKdKrGAEM BYKCvflJFg6WleCcFGSfjD2wDjSdiEv5rWHnCSrHxRYEJWuYAyR87Ra0lOWmQpY= =S6nb -----END PGP SIGNATURE----- --lCAWRPmW1mITcIfM--