Date: Tue, 20 Dec 2005 23:13:31 +0100 (CET) From: Raaf <raaf@luna.afraid.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/90719: [patch] multimedia/vlc fails to build with firefox-plugin Message-ID: <20051220221331.18B5A5A@gw.luna.afraid.org> Resent-Message-ID: <200512202220.jBKMK3Yd037354@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 90719
>Category: ports
>Synopsis: [patch] multimedia/vlc fails to build with firefox-plugin
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Dec 20 22:20:02 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Raaf
>Release: FreeBSD 6.0-RELEASE i386
>Organization:
>Environment:
System: FreeBSD 6.0-RELEASE
>Description:
If you have WITH_MOZILLA= firefox and WITH_MOZILLA_PLUGIN= yes
defined multimedia/vlc fails to build.
>How-To-Repeat:
Build multimedia/vlc WITH_MOZILLA= firefox and WITH_MOZILLA_PLUGIN= yes
[...]
Making all in mozilla
gmake[2]: Entering directory `/usr/ports/multimedia/vlc/work/vlc-0.8.4/mozilla'
/usr/X11R6/lib/firefox/xpidl -I/usr/X11R6/share/idl/firefox \
-m header -o vlcintf ./vlcintf.idl
./vlcintf.idl:3: can't open included file nsISupports.idl for reading
input callback returned failure
gmake[2]: *** [vlcintf.h] Error 2
gmake[2]: Leaving directory `/usr/ports/multimedia/vlc/work/vlc-0.8.4/mozilla'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/multimedia/vlc/work/vlc-0.8.4'
gmake: *** [all] Error 2
*** Error code 2
Stop in /usr/ports/multimedia/vlc.
>Fix:
Latest firefox has idl files in ${X11BASE}/share/idl/firefox-1.5 while
vlc Makefile has hardcoded path to ${X11BASE}/share/idl/firefox.
There doesn't seem to be a need (anymore) to define XPIDL_INCL,
i think following line of configure.ac now takes care of idl path:
AS_IF([test "${MOZILLA_CONFIG}"], [
if test -z "${XPIDL_INCL}"; then
XPIDL_INCL="`${MOZILLA_CONFIG} --cflags plugin xpcom java` \
`${MOZILLA_CONFIG} --idlflags plugin xpcom java` "
fi
])
Anyway with following patch vlc builds fine:
--- Makefile.orig Tue Dec 20 05:45:38 2005
+++ Makefile Tue Dec 20 22:12:08 2005
@@ -287,8 +287,7 @@
RUN_DEPENDS+= ${X11BASE}/libdata/pkgconfig/firefox-plugin.pc:${PORTSDIR}/www/firefox
CONFIGURE_ENV+= MOZILLA_CONFIG="${X11BASE}/bin/firefox-config" \
- XPIDL="${X11BASE}/lib/firefox/xpidl"\
- XPIDL_INCL="-I${X11BASE}/share/idl/firefox"
+ XPIDL="${X11BASE}/lib/firefox/xpidl"
.else
BUILD_DEPENDS+= ${X11BASE}/libdata/pkgconfig/mozilla-plugin${HEADERS_SUFX}.pc:${PORTSDIR}/www/mozilla${HEADERS_SUFX}
RUN_DEPENDS+= ${X11BASE}/libdata/pkgconfig/mozilla-plugin${HEADERS_SUFX}.pc:${PORTSDIR}/www/mozilla${HEADERS_SUFX}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051220221331.18B5A5A>