From owner-svn-src-all@freebsd.org  Fri Jan  5 17:33:01 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 277CAEB5DB9;
 Fri,  5 Jan 2018 17:33:01 +0000 (UTC)
 (envelope-from eugen@grosbein.net)
Received: from hz.grosbein.net (hz.grosbein.net [78.47.246.247])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id A5034741FE;
 Fri,  5 Jan 2018 17:33:00 +0000 (UTC)
 (envelope-from eugen@grosbein.net)
Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be
 forged))
 by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id w05HWpLg039903
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 5 Jan 2018 18:32:52 +0100 (CET)
 (envelope-from eugen@grosbein.net)
X-Envelope-From: eugen@grosbein.net
X-Envelope-To: mjoras@freebsd.org
Received: from [10.58.0.4] ([10.58.0.4])
 by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id w05HWmkM018901
 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
 Sat, 6 Jan 2018 00:32:48 +0700 (+07)
 (envelope-from eugen@grosbein.net)
Subject: Re: svn commit: r327559 - in head: . sys/net
To: Matt Joras <mjoras@freebsd.org>, Steven Hartland <steven@multiplay.co.uk>
References: <201801042005.w04K5liB049411@repo.freebsd.org>
 <5A4E9397.9000308@grosbein.net>
 <f133b587-1f7e-4594-31d1-974775ad55be@freebsd.org>
 <5A4EDC62.50508@grosbein.net>
 <c42bfb9e-e583-aca3-bf0d-4d92c0153d2f@multiplay.co.uk>
 <5A4F824C.1060405@grosbein.net>
 <97d173fb-4f47-609d-8319-07282a283473@multiplay.co.uk>
 <CADdTf+i47-X1HVb=JBFi53wOgbX1x1euHr53-YyqNDDFNF9PLw@mail.gmail.com>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
From: Eugene Grosbein <eugen@grosbein.net>
Message-ID: <5A4FB6BC.6090506@grosbein.net>
Date: Sat, 6 Jan 2018 00:32:44 +0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <CADdTf+i47-X1HVb=JBFi53wOgbX1x1euHr53-YyqNDDFNF9PLw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=2.2 required=5.0 tests=BAYES_00, LOCAL_FROM, RDNS_NONE
 autolearn=no autolearn_force=no version=3.4.1
X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1%
 *      [score: 0.0000] *  2.6 LOCAL_FROM From my domains
 *  1.9 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on hz.grosbein.net
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jan 2018 17:33:01 -0000

06.01.2018 0:28, Matt Joras wrote:

> For what it's worth, this was the conclusion I came to, and at Isilon
> we've made the same change being discussed here. For the case of
> drivers that end up using a queue index for the flowid, you end up
> with pathological behavior on the lagg; the flowid ends up getting
> right shifted by (default) 16. So in the case of e.g. two bxe(4)
> interfaces with 4 queues, you always end up choosing the interface in
> the lagg at index 0.

Not all drivers have this bug. These are drivers that needs to be fixed to not shift by 16, not lagg.