From owner-svn-ports-head@FreeBSD.ORG  Tue Apr  7 17:13:49 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CF00191A;
 Tue,  7 Apr 2015 17:13:49 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A2B8F3D8;
 Tue,  7 Apr 2015 17:13:48 +0000 (UTC)
Received: from [192.168.1.22] (159.Red-79-148-64.dynamicIP.rima-tde.net
 [79.148.64.159])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 0ED5A435AC;
 Tue,  7 Apr 2015 12:13:45 -0500 (CDT)
Message-ID: <55241047.50102@marino.st>
Date: Tue, 07 Apr 2015 19:13:43 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Bryan Drewery <bdrewery@FreeBSD.org>, John Marino <marino@FreeBSD.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r383184 - in head/devel/libc++: . files
References: <201504040022.t340MwUc082274@svn.freebsd.org>
 <55240C73.9050209@FreeBSD.org>
In-Reply-To: <55240C73.9050209@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Apr 2015 17:13:49 -0000

On 4/7/2015 18:57, Bryan Drewery wrote:
> On 4/3/2015 7:22 PM, John Marino wrote:
>> Author: marino
>> Date: Sat Apr  4 00:22:57 2015
>> New Revision: 383184
>> URL: https://svnweb.freebsd.org/changeset/ports/383184
>>
>> Log:
>>   devel/libc++: Mainly fix DragonFly support.
>>   
>>   This port was originally fixed in dports using alias:10 but this fix
>>   was faulty.  The libc++ headers reference __FreeBSD__ so alias won't
>>   work.  It needs to be patched to check __DragonFly__, including a file
>>   that was the subject of EXTRA_PATCHES.
> 
> Can you please upstream the DragonFly support?
> 
> I am working on getting dim's patch into the port to update it and
> conflicting with all of this.

Had I create the patch a week later, then I would have had to rework my
patch.  Sometimes this happen.


> I think it will be simpler to use CPPFLAGS+=-D__FreeBSD__ to cover most
> of these cases without patches.

Well, it didn't.



>>   Moreover, the port was installing the .orig files left over from
>>   patching.  I remove these in post-patch now.
> 
> I don't think this is a problem worth fixing. check-plist already
> ignores .orig files.

Well, it's fixed now so the fix isn't work removing.