From owner-svn-src-head@FreeBSD.ORG Mon Dec 29 20:50:38 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73BAB106564A; Mon, 29 Dec 2008 20:50:38 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 468D38FC32; Mon, 29 Dec 2008 20:50:38 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 360951A3C3D; Mon, 29 Dec 2008 12:50:38 -0800 (PST) Date: Mon, 29 Dec 2008 12:50:38 -0800 From: Alfred Perlstein To: Poul-Henning Kamp Message-ID: <20081229205038.GL20239@elvis.mu.org> References: <20081228053530.GF18389@elvis.mu.org> <32523.1230450781@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32523.1230450781@critter.freebsd.dk> User-Agent: Mutt/1.4.2.3i Cc: Scott Long , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , "mav@freebsd.org" , "M. Warner Losh" Subject: Re: svn commit: r186182 - head/sys/dev/ata X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Dec 2008 20:50:39 -0000 * Poul-Henning Kamp [081227 23:53] wrote: > In message <20081228053530.GF18389@elvis.mu.org>, Alfred Perlstein writes: > >* Scott Long [081226 18:34] wrote: > > >> I prefer to do nothing. It's not unsafe or erroneous to access cfg > >> registers. But if some kind of message does get added, I insist that > >> it drop all pretenses and say, "you're too poor to run freebsd, come > >> back when you can afford better hardware.". :) > > > >Well that could be the result of a driver that has a "bug" that > >makes it access cfg space when it does not need to, as what seems > >to have just been fixed. > > How about adding a counter and a rate warning under INVARIANTS ? Yeah, again it's one of those things that I think I understand at a high level, but I don't have the hands-on skills to do it in a timely manner. I'll look into it if people keep tripping over this. thank you, -Alfred