Date: Mon, 6 Dec 1999 06:30:01 -0800 (PST) From: TATEOKA Takamichi <tate@spa.is.uec.ac.jp> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/13691: tcpslice barfs on >2GB trace file Message-ID: <199912061430.GAA04126@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/13691; it has been noted by GNATS. From: TATEOKA Takamichi <tate@spa.is.uec.ac.jp> To: sheldonh@uunet.co.za Cc: freebsd-gnats-submit@freebsd.org Subject: Re: bin/13691: tcpslice barfs on >2GB trace file Date: Mon, 06 Dec 1999 23:27:50 +0900 Hi, From: Sheldon Hearn <sheldonh@uunet.co.za> > I know it's been a while since you reported your problem with tcpslice, > but I was wondering whether you could test out the following patch from > the author of tcpslice, without any of the modifications you made > yourself, and tell me whether the author has come up with a fix that > works for you. I'm sorry that I cannot do actual test since I already removed a large (4.8GB!) dump file because of disk shortage. However, I think the author of tcpslice makes the patch against the newest version of tcpslice released from LBL. # ftp://ftp.ee.lbl.gov/tcpslice-1.1a3.tar.Z The LBL version of tcpslice already uses portable "off_t" for file offsets. In past, I compiled LBL's tcpslice on the Large File Compilation Environment of SUN Solaris 2.6 (this environment is very similar to the nature of FreeBSD). I only replaced fseek/ftell with fseeko/ftello respectively. It works great for a dump file larger than 2GB. So, I think the author's patch is good enough for tcpslice.c of LBL's tcpslice. However, we should replace fseek/ftell in search.c also, I think. A small but important difference between FreeBSD's tcpslice and LBL's one is the definition of num_bytes in search.c:sf_find_end(). FreeBSD's code defines it as u_int num_bytes; on the other hand, LBL's code defines it as int num_bytes; This difference makes a sign expansion problem that I reported last time. LBL's code never makes the problem since it is signed and no need for a sign expansion. Thanks, TATEOKA, Takamichi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199912061430.GAA04126>