From owner-freebsd-bugs@FreeBSD.ORG Tue Jul 29 18:32:04 2014 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4DCF1791 for ; Tue, 29 Jul 2014 18:32:04 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 35A9F22DB for ; Tue, 29 Jul 2014 18:32:04 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s6TIW401080761 for ; Tue, 29 Jul 2014 18:32:04 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 192247] New: [cam][cd] READ_CD_CAPACITY could be reaped from scsi_cd.h Date: Tue, 29 Jul 2014 18:32:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: yaneurabeya@gmail.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jul 2014 18:32:04 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192247 Bug ID: 192247 Summary: [cam][cd] READ_CD_CAPACITY could be reaped from scsi_cd.h Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: yaneurabeya@gmail.com READ_CAPACITY and READ_CD_CAPACITY have the same value in cam(4). Not sure if this was intentional given the comment in scsi_cd.h, but the value in scsi_cd.h could probably be reaped because it wasn't used in the tree (apart from that header). $ egrep 'READ_.*CAPACITY' /usr/src/sys/cam/scsi/scsi_all.h /usr/src/sys/cam/scsi/scsi_cd.h /usr/src/sys/cam/scsi/scsi_all.h:#define READ_CAPACITY 0x25 /usr/src/sys/cam/scsi/scsi_cd.h:#define READ_CD_CAPACITY 0x25 /* slightly different from disk */ $ grep -r READ_CD_CAPACITY /usr/src/ /usr/src/sys/cam/scsi/scsi_cd.h:#define READ_CD_CAPACITY 0x25 /* slightly different from disk */ $ -- You are receiving this mail because: You are the assignee for the bug.