From owner-svn-src-all@freebsd.org  Fri Apr  5 13:48:50 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DDB931577AFD;
 Fri,  5 Apr 2019 13:48:50 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: from mail-io1-f51.google.com (mail-io1-f51.google.com
 [209.85.166.51])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7720091CC3;
 Fri,  5 Apr 2019 13:48:50 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: by mail-io1-f51.google.com with SMTP id f6so5054114iop.3;
 Fri, 05 Apr 2019 06:48:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=xV0jIQi4BLDoClgO49LlGGZ+jS/U/74WxmtrzWzNnqI=;
 b=T5+I9SsWot+ehG8ijhsNZQ/JEZqBTRD/pQ7RPEXbA5FARi6cjUrxE0qyMQJ+MSglZK
 t8FXPOvNcP+7m7TZr7LjyklUMFUQrf9jFtZHVw6yGhk9LIjJ170BeIcP0PJRVqwMNz+B
 CiILzK8S3g0sYjRO6Aa9Pm1m5J3YQXK52v7VbkaOJd7OkPdFLzHsKNN8YlSU3FrBueCz
 rzPbIl34sv6PHzICW62W7eGRvjpB8YX78Ar7lzah78rfBR0ILJN0T6PwGeGFlG2tVZhs
 UlkkNp+Fx7UHhq4osidAxLspHB/eVKseLd1EQuulPbO/Wxom/ChtwDCnLIyufIWU2qUM
 FXAQ==
X-Gm-Message-State: APjAAAUW2kJ/fkH4Vxv8OUMwniY4tDb6a0S4zpr44xoN59JrS3rktvpe
 cjD5VqY4NxweQerHXjYpMlLyXD1o6/niHgueB2GMmg==
X-Google-Smtp-Source: APXvYqz+Z8ODGl/Dfzji4kvWt8+zv9MSkTC+HK4+8t7TzYlh4ZjICt3qXiKkX5oKpw7I2JM2/pwTS2Oh/JDBdTpVjkw=
X-Received: by 2002:a5e:9e0d:: with SMTP id i13mr9312873ioq.156.1554471760153; 
 Fri, 05 Apr 2019 06:42:40 -0700 (PDT)
MIME-Version: 1.0
References: <201904050221.x352LGjU015040@repo.freebsd.org>
 <201904050449.x354nUEC036896@gndrsh.dnsmgr.net>
In-Reply-To: <201904050449.x354nUEC036896@gndrsh.dnsmgr.net>
From: Ed Maste <emaste@freebsd.org>
Date: Fri, 5 Apr 2019 09:59:57 -0400
Message-ID: <CAPyFy2C3KXTB7EKnp1PJigjUXY3xB_+PUddi43hjp5oKpZP56w@mail.gmail.com>
Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs
To: "Rodney W. Grimes" <rgrimes@freebsd.org>
Cc: Xin LI <delphij@freebsd.org>, src-committers <src-committers@freebsd.org>, 
 svn-src-all <svn-src-all@freebsd.org>,
 svn-src-head <svn-src-head@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-Rspamd-Queue-Id: 7720091CC3
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.87 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.87)[-0.869,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Apr 2019 13:48:51 -0000

On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
>

> > +static const u_char dot_name[] = {
> > +     '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > +static const u_char dotdot_name[] = {
> > +     '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > +
>
> Does it make since to encode these as hex or octal constants,
> one can not tell that those are different values in an easy
> manner.  They all look like '.' in the diff, and probably
> in most editors.

They are all either '.' or ' ', the commas are just list separators.
IMO spaces after the commas would make it slightly easier to see.