From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Dec  3 12:40:28 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C92F316A4CE
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Fri,  3 Dec 2004 12:40:28 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9767043D5A
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Fri,  3 Dec 2004 12:40:28 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iB3CeSSq055538
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Fri, 3 Dec 2004 12:40:28 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iB3CeSjf055536;
	Fri, 3 Dec 2004 12:40:28 GMT
	(envelope-from gnats)
Resent-Date: Fri, 3 Dec 2004 12:40:28 GMT
Resent-Message-Id: <200412031240.iB3CeSjf055536@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Anton Berezin <tobez@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D244716A4CE
	for <FreeBSD-gnats-submit@freebsd.org>;
	Fri,  3 Dec 2004 12:36:02 +0000 (GMT)
Received: from heechee.tobez.org (heechee.tobez.org [217.157.39.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 191F143D3F
	for <FreeBSD-gnats-submit@freebsd.org>;
	Fri,  3 Dec 2004 12:36:02 +0000 (GMT)	(envelope-from tobez@tobez.org)
Received: by heechee.tobez.org (Postfix, from userid 1001)
	id CEE5C175D1; Fri,  3 Dec 2004 13:36:00 +0100 (CET)
Message-Id: <20041203123600.CEE5C175D1@heechee.tobez.org>
Date: Fri,  3 Dec 2004 13:36:00 +0100 (CET)
From: Anton Berezin <tobez@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Subject: ports/74647: fix lang/php4 configure to detect various crypt()s on
	64-bit platforms
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Anton Berezin <tobez@FreeBSD.org>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Dec 2004 12:40:28 -0000


>Number:         74647
>Category:       ports
>Synopsis:       fix lang/php4 configure to detect various crypt()s on 64-bit platforms
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 03 12:40:28 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Anton Berezin
>Release:        FreeBSD 5.3-STABLE amd64
>Organization:
>Environment:

	
>Description:
The configure script fails to detect various crypt()-related
functionality (DES/MD5/Blowfish) on amd64 platform.
>How-To-Repeat:
Build lang/php4 on an amd64 system, observe configure output.
>Fix:

--- Makefile.orig	Tue Nov 30 22:14:27 2004
+++ Makefile	Tue Nov 30 22:14:51 2004
@@ -164,6 +164,7 @@ post-patch:
 	@${TOUCH} ${WRKSRC}/ext/php_config.h
 	@${REINPLACE_CMD} "s|^\(extension_dir\)|; \1|" ${WRKSRC}/php.ini-*
 	@${REINPLACE_CMD} "s|<crypt.h>|<unistd.h>|g" ${WRKSRC}/configure
+	@${REINPLACE_CMD} "s|HAVE_CRYPT_H|HAVE_UNISTD_H|g" ${WRKSRC}/configure
 
 .if ${PHP_SAPI} == "full"
 pre-configure:


This is needed since without having HAVE_CRYPT_H replaced with
HAVE_UNISTD_H, unistd.h is never included in those pieces of configure
that originally try to include crypt.h.  This goes unnoticed on 32-bit
platforms, since sizeof(int) == sizeof(char *), but leads to a coredump
on 64-bit platforms (well, at least on amd64) when crypt() is implicitly
defined and assumes an int return argument.
>Release-Note:
>Audit-Trail:
>Unformatted: