Date: Thu, 8 Dec 2022 23:24:54 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: Alan Somers <asomers@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6c93a2d0bc37 - main - [skip ci] improvements to cap_sysctl.3 Message-ID: <20221208232454.32fbd074896a1834cd7b2737@bidouilliste.com> In-Reply-To: <CAOtMX2i0=cdjJ6ft2oe9s2EV1soiO=kO1dNofDrMdOh=SK-5Cg@mail.gmail.com> References: <202212081946.2B8Jk1e8070942@gitrepo.freebsd.org> <20221208221501.4abec4c251863fe23a35ce78@bidouilliste.com> <CAOtMX2jZiGLdmhJ2eX5inFkK3oN-Q3dHwumQLuu6QAXkAVKqdw@mail.gmail.com> <20221208225915.72b1b339de1a7962e3e38c9e@bidouilliste.com> <CAOtMX2i0=cdjJ6ft2oe9s2EV1soiO=kO1dNofDrMdOh=SK-5Cg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 8 Dec 2022 15:15:30 -0700 Alan Somers <asomers@freebsd.org> wrote: > On Thu, Dec 8, 2022 at 2:59 PM Emmanuel Vadot <manu@bidouilliste.com> wrote: > > > > On Thu, 8 Dec 2022 14:28:34 -0700 > > Alan Somers <asomers@freebsd.org> wrote: > > > > > On Thu, Dec 8, 2022 at 2:15 PM Emmanuel Vadot <manu@bidouilliste.com> wrote: > > > > > > > > > > > > Hi Alan, > > > > > > > > On Thu, 8 Dec 2022 19:46:01 GMT > > > > Alan Somers <asomers@FreeBSD.org> wrote: > > > > > > > > > The branch main has been updated by asomers: > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=6c93a2d0bc37f0c912e402f3f94c3c01350dca26 > > > > > > > > > > commit 6c93a2d0bc37f0c912e402f3f94c3c01350dca26 > > > > > Author: Alan Somers <asomers@FreeBSD.org> > > > > > AuthorDate: 2022-12-01 16:49:57 +0000 > > > > > Commit: Alan Somers <asomers@FreeBSD.org> > > > > > CommitDate: 2022-12-08 19:45:47 +0000 > > > > > > > > > > [skip ci] improvements to cap_sysctl.3 > > > > > > > > You keep doing commit with this [skip ci] prefix, what is it for ? > > > > AFAIK the official FreeBSD CI doesn't support this and I find that > > > > really ugly to have this in the commit subject. > > > > Mind sharing more on why you add this ? > > > > > > > > Cheers, > > > > > > > > -- > > > > Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org> > > > > > > It tells CI systems not to run any tests on this commit. Both Cirrus > > > and Jenkins understand it, among others. For example, if you browse > > > to https://github.com/freebsd/freebsd-src/commits/main and hover over > > > the green checkmark next to this commit, you'll see a bunch of > > > "skipped" symbols. So I use it just to save resources. I think I > > > could put it on a separate line, though. > > > -Alan > > > > Mhm ok, I find that very ugly, couldn't we add some git push options > > instead ? We use gitlab at current work and we use a lot of those push > > options, this avoid having ugly commit subject. > > > How? What is a "git push option"? https://docs.gitlab.com/ee/user/project/push_options.html This is the same kind of stuff we use when you push some commit authored by someone without a @freebsd.org email address. -- Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20221208232454.32fbd074896a1834cd7b2737>