From owner-svn-src-all@FreeBSD.ORG Fri Dec 3 10:17:10 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 82F1B106566B; Fri, 3 Dec 2010 10:17:10 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (muon.cran.org.uk [IPv6:2a01:348:0:15:5d59:5c40:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id 355808FC0A; Fri, 3 Dec 2010 10:17:10 +0000 (UTC) Received: from muon.cran.org.uk (localhost [127.0.0.1]) by muon.cran.org.uk (Postfix) with ESMTP id 5EC75E7167; Fri, 3 Dec 2010 10:17:09 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=cran.org.uk; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=mail; bh=39vjrn6mjJhz P4VqxfAAJW0ySRY=; b=DpJumU8Hu0ryTFFQN0w53RgW6zwLfWA56/l53ZiGgZ46 F9X0eOAdZ0iXShgoxdbVPIxCsMS+aDixOWI6Cy7xAalfDQTJRPKrFGfjTWWX22OH jMegYQZmGDhlBlPbnXfNy3bRsqLp38A6KO8lXL2hmaZoo1N+MDAsT9hiWAkpDQ4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=cran.org.uk; h=date:from:to :cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; q=dns; s=mail; b=SFthpL cdwaqoNncG/bTD6BlVA37tWLmaZCUzKnjtcrb6StCq4fJFryrEUJLYRURq6Vdvum e7Pgk+W0IxR+xlcFT1cj7phY9b1SJxGZNildqxtW21CR35+Lvkt6ek1Hg6I/CtW7 cVhnhSlaw3lnyo6xMryJWQtuB6C7UWWwUK3OM= Received: from core.draftnet (client-86-31-8-12.midd.adsl.virginmedia.com [86.31.8.12]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA id DE70CE7161; Fri, 3 Dec 2010 10:17:08 +0000 (GMT) Date: Fri, 3 Dec 2010 10:16:51 +0000 From: Bruce Cran To: Bruce Evans Message-ID: <20101203101651.7461ced0@core.draftnet> In-Reply-To: <20101203201705.O2228@besplex.bde.org> References: <201012022219.oB2MJUx5031472@svn.freebsd.org> <20101203201705.O2228@besplex.bde.org> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.1; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Bruce Cran Subject: Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4v... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2010 10:17:10 -0000 On Fri, 3 Dec 2010 20:45:12 +1100 (EST) Bruce Evans wrote: > KASSERT() in little inline functions gives a lot of bloat for such an > unlikely error. Stupid callers can still pass any garbage count > except 0. Yes, this catches a specific case that hps raised a few years ago: sending zero-length packets/frames would fail by causing the system to hang. Should we just document the restriction in the man page and not try and prevent it at runtime? -- Bruce Cran