Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Nov 2012 13:32:25 +0100
From:      Emanuel Haupt <ehaupt@FreeBSD.org>
To:        Eitan Adler <eadler@FreeBSD.org>
Cc:        svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: svn commit: r307902 - head/graphics/grafx2/files
Message-ID:  <20121129133225.9e3dbd297872a7d3d8e949f5@FreeBSD.org>
In-Reply-To: <CAF6rxgkJz3JxRmPZjEvAyGTcd1brH0ECraEqbG=iZB83%2BTmeWg@mail.gmail.com>
References:  <201211281129.qASBT6Aw015051@svn.freebsd.org> <CAF6rxgnp0fZkScwc9HwKxPdm2KbT4pKsO%2B79t7bWVMop6JtXfA@mail.gmail.com> <20121128213502.b5cd8fab508df17bad16c635@FreeBSD.org> <CAF6rxgkJz3JxRmPZjEvAyGTcd1brH0ECraEqbG=iZB83%2BTmeWg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Eitan Adler <eadler@FreeBSD.org> wrote:
> On 28 November 2012 15:35, Emanuel Haupt <ehaupt@freebsd.org> wrote:
> > Eitan Adler <eadler@freebsd.org> wrote:
> >> On 28 November 2012 06:29, Emanuel Haupt <ehaupt@freebsd.org>
> >> wrote:
> >> > Author: ehaupt
> >> > Date: Wed Nov 28 11:29:06 2012
> >> > New Revision: 307902
> >> > URL: http://svnweb.freebsd.org/changeset/ports/307902
> >> >
> >> > Log:
> >> >   Add patchfile.
> >>
> >> What does the patchfile do? Why is it needed? Was upstream
> >> contacted?
> >>
> >> - these should be documented in the log message.
> >
> > It is part of the update 2 minutes earlier. I thought this was
> > obvious.
> 
> Ah, I didn't see this.   In any case it would help to document these
> things - especially the part about whether upstream ACKed/NACKed the
> patch.

You're right, I should have mentioned that in my follow up commit. The
patch has been submitted upstream. Haven't heard back so far.

Emanuel



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121129133225.9e3dbd297872a7d3d8e949f5>