From owner-cvs-all@FreeBSD.ORG Wed Apr 14 07:57:50 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B9E0716A4CE; Wed, 14 Apr 2004 07:57:50 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B321643D58; Wed, 14 Apr 2004 07:57:50 -0700 (PDT) (envelope-from green@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i3EEvoGe069563; Wed, 14 Apr 2004 07:57:50 -0700 (PDT) (envelope-from green@repoman.freebsd.org) Received: (from green@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i3EEvo7h069562; Wed, 14 Apr 2004 07:57:50 -0700 (PDT) (envelope-from green) Message-Id: <200404141457.i3EEvo7h069562@repoman.freebsd.org> From: Brian Feldman Date: Wed, 14 Apr 2004 07:57:50 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/sound/isa ad1816.c ess.c mss.c sb16.c sb8.c sbc.c src/sys/dev/sound/pci cmi.c csa.c csapcm.c ds1.c emu10k1.c ich.c t4dwave.c src/sys/dev/sound/pcm sound.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2004 14:57:50 -0000 green 2004/04/14 07:57:50 PDT FreeBSD src repository Modified files: sys/dev/sound/isa ad1816.c ess.c mss.c sb16.c sb8.c sbc.c sys/dev/sound/pci cmi.c csa.c csapcm.c ds1.c emu10k1.c ich.c t4dwave.c sys/dev/sound/pcm sound.h Log: The newpcm headers currently #define away INTR_MPSAFE and INTR_TYPE_AV because they bogusly check for defined(INTR_MPSAFE) -- something which never was a #define. Correct the definitions. This make INTR_TYPE_AV finally get used instead of the lower-priority INTR_TYPE_TTY, so it's quite possible some improvement will be had on sound driver performance. It would also make all the drivers marked INTR_MPSAFE actually run without Giant (which does seem to work for me), but: INTR_MPSAFE HAS BEEN REMOVED FROM EVERY SOUND DRIVER! It needs to be re-added on a case-by-case basis since there is no one who will vouch for which sound drivers, if any, willy actually operate correctly without Giant, since there hasn't been testing because of this bug disabling INTR_MPSAFE. Found by: "Yuriy Tsibizov" Revision Changes Path 1.32 +1 -1 src/sys/dev/sound/isa/ad1816.c 1.30 +1 -1 src/sys/dev/sound/isa/ess.c 1.88 +2 -2 src/sys/dev/sound/isa/mss.c 1.83 +1 -1 src/sys/dev/sound/isa/sb16.c 1.76 +1 -1 src/sys/dev/sound/isa/sb8.c 1.40 +1 -1 src/sys/dev/sound/isa/sbc.c 1.27 +1 -1 src/sys/dev/sound/pci/cmi.c 1.29 +1 -1 src/sys/dev/sound/pci/csa.c 1.30 +1 -1 src/sys/dev/sound/pci/csapcm.c 1.39 +1 -1 src/sys/dev/sound/pci/ds1.c 1.48 +1 -1 src/sys/dev/sound/pci/emu10k1.c 1.41 +1 -1 src/sys/dev/sound/pci/ich.c 1.43 +1 -1 src/sys/dev/sound/pci/t4dwave.c 1.58 +3 -8 src/sys/dev/sound/pcm/sound.h