From owner-freebsd-current@FreeBSD.ORG Wed Sep 3 15:08:09 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC65716A4BF; Wed, 3 Sep 2003 15:08:09 -0700 (PDT) Received: from mail.cyberonic.com (mail.cyberonic.com [4.17.179.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1AFE343FE3; Wed, 3 Sep 2003 15:08:08 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (node-40244c0a.sfo.onnet.us.uu.net [64.36.76.10]) by mail.cyberonic.com (8.12.8/8.12.5) with ESMTP id h83Mpwbi000423; Wed, 3 Sep 2003 18:51:59 -0400 Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.9/8.11.6) id h83M7vfZ053568; Wed, 3 Sep 2003 15:07:57 -0700 (PDT) (envelope-from jmg) Date: Wed, 3 Sep 2003 15:07:57 -0700 From: John-Mark Gurney To: Jens Rehsack Message-ID: <20030903220756.GG16766@funkthat.com> Mail-Followup-To: Jens Rehsack , Michal Mertl , roger@freebsd.org, current@freebsd.org References: <3F56651C.5050108@liwing.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F56651C.5050108@liwing.de> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: roger@freebsd.org cc: Michal Mertl cc: current@freebsd.org Subject: Re: bktr(4) bufs plus patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2003 22:08:09 -0000 Jens Rehsack wrote this message on Wed, Sep 03, 2003 at 22:03 +0000: > Michal Mertl wrote: > >I found 2 bugs and some potential problems in bktr(4) code. > > > >Bug 1: > >Compilation with options BKTR_USE_FREEBSD_SMBUS failes. Error is > >that code tries to use iicbus which isn't defined where it looks for > >it. I added it there and the compilation and detection goes fine. I don't > >know how to actually test it though. > > > > [...] > > Will anyone responsible take notice of this patch and commit it? I'm not responsible, but I will take notice of it. Once I get my lab up and running (hopefully in the next week), I can test this and see how it works. Could we get it submitted as a pr (if it isn't already), and assign it to me? (I'll assign it to myself once I know the PR). -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."