From nobody Fri Dec 9 01:00:03 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NSt3k3G3Mz4jxqF for ; Fri, 9 Dec 2022 01:00:18 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NSt3j35y9z42tm for ; Fri, 9 Dec 2022 01:00:17 +0000 (UTC) (envelope-from ricera10@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=ricera10@gmail.com; dmarc=none Received: by mail-ej1-f51.google.com with SMTP id n21so8014408ejb.9 for ; Thu, 08 Dec 2022 17:00:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x1lq8MLqezpjOaih4zpIkI/TnfVU0XA1HUA7YPkEB+E=; b=RxkycTtA+6XoFiy1eiKQzWZHGhFGobXoJKGc2G5pcOzavc8QfkuEwdDHHjy+8bNFFY OweCjsDUYSiXPZLXy95ur4maV/i0c1P/T9Wy9ZDdaQl0eZgtNH83zf1KC7R4aarGCT2g qlpzNuUQAzaU3aEGfMc6wcaPEQm9VydjXB3U4X7PmdxmqK9c8GV7UmeifTEPkiNrsr4f 5XK2yFcZxOfMZAIuT1BOE+lUaPAC2pE3reIiVxiCzIl0OVt7GLHYbLGmkzpSPUN3q51u G0jvfPIopP/qi+4IFahKNiuwPNnLoAVva/PdI9KXUrQfjrOdGWFtzJdxVH/1vuyhvvoU KLgw== X-Gm-Message-State: ANoB5pngol/Xpz0Imj+nbOJSPzS12kAoqnWW8UDy9OaSZaCeDfzvL3Qz 9hbXH8NBXCzTHCgJi5YrrOu2orivqbIEQg== X-Google-Smtp-Source: AA0mqf64YsDZuoDpXi9Y2eJiP9qZ4b7YfB0/SGIDANlBAbfD+pJh0MloDlI00p+29LqUhAlRiBDecg== X-Received: by 2002:a17:907:3ac2:b0:7c1:765:9cfc with SMTP id fi2-20020a1709073ac200b007c107659cfcmr2350257ejc.34.1670547615497; Thu, 08 Dec 2022 17:00:15 -0800 (PST) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com. [209.85.208.43]) by smtp.gmail.com with ESMTPSA id kq7-20020a170906abc700b0077f20a722dfsm4587480ejb.165.2022.12.08.17.00.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 17:00:14 -0800 (PST) Received: by mail-ed1-f43.google.com with SMTP id z92so1200216ede.1 for ; Thu, 08 Dec 2022 17:00:14 -0800 (PST) X-Received: by 2002:a05:6402:790:b0:46c:cd6e:811a with SMTP id d16-20020a056402079000b0046ccd6e811amr13579255edy.352.1670547613985; Thu, 08 Dec 2022 17:00:13 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202205232354.24NNs69N032987@gitrepo.freebsd.org> In-Reply-To: From: Eric Joyner Date: Thu, 8 Dec 2022 17:00:03 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: cdcd52d41e24 - main - irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000001cc81205ef5aadc9" X-Spamd-Result: default: False [-1.76 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_SPAM_SHORT(0.34)[0.337]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RWL_MAILSPIKE_GOOD(-0.10)[209.85.218.51:from]; RCVD_IN_DNSWL_NONE(0.00)[209.85.218.51:from,209.85.208.43:received]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; RCPT_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[freebsd.org]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Queue-Id: 4NSt3j35y9z42tm X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N --0000000000001cc81205ef5aadc9 Content-Type: text/plain; charset="UTF-8" Yeah, I was able to repro it and get what I think is the error in a nicer-to-read set of lines: Building /root/build/head/obj/root/build/head/src/amd64.amd64/lib/ofed/libirdma/libirdma.a building static irdma library Building /root/build/head/obj/root/build/head/src/amd64.amd64/lib/ofed/libirdma/libirdma.so.1.full building shared library libirdma.so.1 /usr/local/bin/x86_64-unknown-freebsd14.0-ld: duplicate expression `*' in version information collect2: error: ld returned 1 exit status *** [libirdma.so.1.full] Error code 1 What does that even mean? I don't know anything about building libraries. - Eric On Wed, Dec 7, 2022 at 1:05 PM John Baldwin wrote: > On 6/13/22 2:18 PM, Eric Joyner wrote: > > On Fri, Jun 10, 2022 at 3:29 PM John Baldwin wrote: > > > >> On 5/23/22 4:54 PM, Eric Joyner wrote: > >>> The branch main has been updated by erj: > >>> > >>> URL: > >> > https://cgit.FreeBSD.org/src/commit/?id=cdcd52d41e246ba1c0fcfad0769bd691487355ef > >>> > >>> commit cdcd52d41e246ba1c0fcfad0769bd691487355ef > >>> Author: Bartosz Sobczak > >>> AuthorDate: 2022-05-23 23:39:27 +0000 > >>> Commit: Eric Joyner > >>> CommitDate: 2022-05-23 23:52:49 +0000 > >>> > >>> irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 > >>> > >>> This is an initial commit for RDMA FreeBSD driver for Intel(R) > >> Ethernet > >>> Controller E810, called irdma. Supporting both RoCEv2 and iWARP > >>> protocols in per-PF manner, RoCEv2 being the default. > >>> > >>> Testing has been done using krping tool, perftest, ucmatose, > rping, > >>> ud_pingpong, rc_pingpong and others. > >>> > >>> Signed-off-by: Eric Joyner > >>> > >>> Reviewed by: #manpages (pauamma_gundo.com) [documentation] > >>> MFC after: 1 week > >>> Relnotes: yes > >>> Sponsored by: Intel Corporation > >>> Differential Revision: https://reviews.freebsd.org/D34690 > >> > >> I'm trying to get the tree building again with GCC and ld.bfd does not > like > >> libirdma.map at all complaining with an error: > >> > >> duplicate expression '*' in version information > >> > >> I looked at the version map, and it seems rather bogus to me and not > like > >> version maps used anywhere else. It seems to be exporting all symbols > in > >> two different versions? That would seem to defeat the point of having > >> symbol versions? > >> > >> /* Export symbols should be added below according to > >> Documentation/versioning.md document. */ > >> IRDMA_1.0 { > >> global: *; > >> local: *; > >> }; > >> > >> IRDMA_1.1 { > >> global: *; > >> } IRDMA_1.0; > >> > >> (I'm also not sure why lld accepts such a version map.) > >> > >> -- > >> John Baldwin > >> > > > > Hi, > > > > I don't know how to answer this; I'm going to forward this to the FreeBSD > > RDMA guy and another one (the first guy might still be out on vacation) > and > > see if they can answer this. > > FYI, this is now the current breakage for the new GCC 12 job in FreeBSD's > CI: > > https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc12_build/47/console > > The error is buried in the log there, but should be obtainable by doing > 'pkg install amd64-gcc12' and 'make CROSS_TOOLCHAIN=amd64-gcc12 buildworld' > on main. > > -- > John Baldwin > > --0000000000001cc81205ef5aadc9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yeah, I was able to repro it and get what I think is the e= rror in a nicer-to-read set of lines:

Building /root/bui= ld/head/obj/root/build/head/src/amd64.amd64/lib/ofed/libirdma/libirdma.a = =C2=A0 =C2=A0 =C2=A0 =C2=A0
building static irdma library =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0
Building /root/build/head/obj/root/build/head/src/amd64.amd64/lib/o= fed/libirdma/libirdma.so.1.full
building shared library libirdma.so.1 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
/usr/loc= al/bin/x86_64-unknown-freebsd14.0-ld: duplicate expression `*' in versi= on information =C2=A0 =C2=A0
collect2: error: ld returned 1 exit status= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
*** [libirdma.so.1.full= ] Error code 1=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0

What does that even mean? I don'= ;t know anything about building libraries.

- Eric<= /div>

On Wed, Dec 7, 2022 at 1:05 PM John Baldwin <jhb@freebsd.org> wrote:
On 6/13/22 2:18 PM, Eric Joyner wrote:
> On Fri, Jun 10, 2022 at 3:29 PM John Baldwin <jhb@freebsd.org> wrote:
>
>> On 5/23/22 4:54 PM, Eric Joyner wrote:
>>> The branch main has been updated by erj:
>>>
>>> URL:
>> https://c= git.FreeBSD.org/src/commit/?id=3Dcdcd52d41e246ba1c0fcfad0769bd691487355ef
>>>
>>> commit cdcd52d41e246ba1c0fcfad0769bd691487355ef
>>> Author:=C2=A0 =C2=A0 =C2=A0Bartosz Sobczak <bartosz.sobczak@intel.com>
>>> AuthorDate: 2022-05-23 23:39:27 +0000
>>> Commit:=C2=A0 =C2=A0 =C2=A0Eric Joyner <erj@FreeBSD.org>=
>>> CommitDate: 2022-05-23 23:52:49 +0000
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0irdma: Add RDMA driver for Intel(R) = Ethernet Controller E810
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0This is an initial commit for RDMA F= reeBSD driver for Intel(R)
>> Ethernet
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Controller E810, called irdma.=C2=A0= Supporting both RoCEv2 and iWARP
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0protocols in per-PF manner, RoCEv2 b= eing the default.
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Testing has been done using krping t= ool, perftest, ucmatose, rping,
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0ud_pingpong, rc_pingpong and others.=
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Signed-off-by: Eric Joyner <erj@F= reeBSD.org>
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Reviewed by:=C2=A0 =C2=A0 #manpages = (= pauamma_gundo.com) [documentation]
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0MFC after:=C2=A0 =C2=A0 =C2=A0 1 wee= k
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Relnotes:=C2=A0 =C2=A0 =C2=A0 =C2=A0= yes
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0Intel Corp= oration
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Differential Revision:=C2=A0 https://reviews.freebsd.org/D34690
>>
>> I'm trying to get the tree building again with GCC and ld.bfd = does not like
>> libirdma.map at all complaining with an error:
>>
>> duplicate expression '*' in version information
>>
>> I looked at the version map, and it seems rather bogus to me and n= ot like
>> version maps used anywhere else.=C2=A0 It seems to be exporting al= l symbols in
>> two different versions?=C2=A0 That would seem to defeat the point = of having
>> symbol versions?
>>
>> /* Export symbols should be added below according to
>>=C2=A0 =C2=A0 =C2=A0 Documentation/versioning.md document. */
>> IRDMA_1.0 {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 global: *;
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 local: *;
>> };
>>
>> IRDMA_1.1 {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 global: *;
>> } IRDMA_1.0;
>>
>> (I'm also not sure why lld accepts such a version map.)
>>
>> --
>> John Baldwin
>>
>
> Hi,
>
> I don't know how to answer this; I'm going to forward this to = the FreeBSD
> RDMA guy and another one (the first guy might still be out on vacation= ) and
> see if they can answer this.

FYI, this is now the current breakage for the new GCC 12 job in FreeBSD'= ;s CI:

https://ci.freebsd.org/job/FreeB= SD-main-amd64-gcc12_build/47/console

The error is buried in the log there, but should be obtainable by doing
'pkg install amd64-gcc12' and 'make CROSS_TOOLCHAIN=3Damd64-gcc= 12 buildworld'
on main.

--
John Baldwin

--0000000000001cc81205ef5aadc9--