Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Apr 2001 09:24:03 -0400
From:      Chris Faulhaber <jedgar@fxp.org>
To:        Maxime Henrion <mux@qualys.com>
Cc:        audit@FreeBSD.org
Subject:   Re: [PATCH] wall.c changes from OpenBSD
Message-ID:  <20010427092403.A32859@peitho.fxp.org>
In-Reply-To: <20010427150436.A1170@nebula.cybercable.fr>; from mux@qualys.com on Fri, Apr 27, 2001 at 03:04:36PM %2B0200
References:  <20010427150436.A1170@nebula.cybercable.fr>

next in thread | previous in thread | raw e-mail | index | archive | help

--Dxnq1zWXvFF0Q93v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 27, 2001 at 03:04:36PM +0200, Maxime Henrion wrote:
> 	Hello,
>=20
>=20
> This patch makes wall open the file with the egid, as taken from the
> OpenBSD mbox of Kris.  I changed several err() to errx() and added some
> dots to end of sentences to match OpenBSD and reduce the diffs.
>=20

I disagree with the err() -> errx() changes.  Since err() prints the
error message from strerror() whereas errx() does not, this patch
removes this reporting ensuring the user will not be informed of the
actual error.

The other change(s) look ok, though.

--=20
Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org
--------------------------------------------------------
FreeBSD: The Power To Serve   -   http://www.FreeBSD.org

--Dxnq1zWXvFF0Q93v
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (FreeBSD)
Comment: FreeBSD: The Power To Serve

iEYEARECAAYFAjrpcvMACgkQObaG4P6BelCMFwCfYGhAMyR7yair7fJJaWwqz2rT
uWgAnRwDMAL5RJYghegGql8E0C1x7zml
=fcve
-----END PGP SIGNATURE-----

--Dxnq1zWXvFF0Q93v--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010427092403.A32859>