Date: Tue, 08 Dec 2015 19:58:42 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: =?UTF-8?Q?Ren=C3=A9_Ladan?= <rene@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r403235 - head/emulators/fuse-roms Message-ID: <9F42699EA35CAC7A011308F0@atuin.in.mat.cc> In-Reply-To: <535A55E7-560F-4F2C-B9D4-AB83FFAB3C12@adamw.org> References: <201512072100.tB7L0Gnj081781@repo.freebsd.org> <0644124C99ECCEA1DF8E9EC0@atuin.in.mat.cc> <CADL2u4itn-bkKZkKj7rq9RGtkKpqQFJsh9pLUTiFKQ8bdg8Ssw@mail.gmail.com> <98D8063B4D072B57DAA53BE8@ogg.in.absolight.net> <CADL2u4jdeGOR-MMgbbuaGYbHMXuPT_Jn43jXpBxb_9Hu=-70Ag@mail.gmail.com> <290DB4608132EE92B98C7908@ogg.in.absolight.net> <535A55E7-560F-4F2C-B9D4-AB83FFAB3C12@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========DAAFBDC6A737C6B1BDE9==========
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
+--On 8 d=C3=A9cembre 2015 07:46:38 -0700 Adam Weinberger <adamw@adamw.org>
wrote:
|> On 8 Dec, 2015, at 4:45, Mathieu Arnold <mat@FreeBSD.org> wrote:
|>=20
|>=20
|>=20
|> +--On 8 d=C3=A9cembre 2015 11:46:01 +0100 Ren=C3=A9 Ladan =
<rene@freebsd.org>
|> wrote:
|> | 2015-12-08 11:29 GMT+01:00 Mathieu Arnold <mat@freebsd.org>:
|> |> +--On 8 d=C3=A9cembre 2015 10:08:19 +0100 Ren=C3=A9 Ladan =
<rene@freebsd.org>
|> |> wrote:
|> |> | 2015-12-08 10:04 GMT+01:00 Mathieu Arnold <mat@freebsd.org>:
|> |> |> +--On 7 d=C3=A9cembre 2015 21:00:16 +0000 Rene Ladan =
<rene@FreeBSD.org>
|> |> |> wrote:
|> |> |> | +DOCS_PLIST_FILES=3D%%DOCSDIR%%/rom-distribution.txt
|> |> |>=20
|> |> |> When possible, don't use %%FOO%% thingies in PLIST_FILES, you can
|> |> |> use ${DOCSDIR} directly.
|> |> |>=20
|> |> | I think I tried that before. It would almost work but "poudriere
|> |> | testport" would fail.
|> |>=20
|> |> Then there was a bug in poudriere testport at that time. It now =
works.
|> |>=20
|> | That was in the previous version (3.10.9 ?). 'make check-plist' worked
|> | fine. I'll change the line next time (but why is it bad?)
|>=20
|> The only reason there are %%foo%% thingies is because pkg-plist is a
|> static file, and we need some way to do the variable expansion in them.
|> The PLIST_FILES is in the Makefile, you can put the correct variables
|> directly.
|=20
| Wouldn't using ${DOCSDIR_REL} be closer to what %%DOCSDIR%% expands to?
Well, it doesn't matter. If you want to write 4 more characters so that
you get a relative path that needs to be made absolute later, you can.
--=20
Mathieu Arnold
--==========DAAFBDC6A737C6B1BDE9==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJWZyhiXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IEs8P/0zpGM4WngFXGXg7oLdD22bD
Jiw6O1EmcF9hNeCy5MsLk4nQQeTmxjlMSkNuiGkSHjkC3aO6KzMb3NjaUx/MUcNP
/mUZScUrUI3wMqlBNoaNpFGj90oCpB3aNJk/af9FqVjGgBqhuE4rej2i3i/k3OB/
lpGyiXA3emOYTfjOKVE8DYUIomJnaRmXSTimR9dHx0tSR+msbCTqgjh1l3QZ3mUv
vA4IvIxvrYuTnT6KG+JHRptS07nTc39n/aQ7xLqXCok0d9zhL9+LXuU45ewfx0DF
AVsnRIfgHJEW4GzoiwGU7YmheRjOxzwVqWDf2mpyql1kZpVfTSKRKj7Gpl/20/oV
DlzNuYAlMkd7Gxk81baweVkHa7eLlGuVN1hPdkUjsmPzoWquQ94+HD79JmaVl7/o
+olThaAVOndl+9EXpeykWFNfD7aGxk7wDTt56ykaCYqX+MeJwKN3XzKhVbr8JJkS
CtXnsxY6Xup7eXfhYt7ml9p3go/3o5pxJrjVeQjI/TwZa6tu3FrdiJxp+F4VUUdT
q+7jdm1tTdNp3xQaykVvGjp3wyLkTdRNeotS5UAgZDC2E9tDeIqfBrSgskvpndhU
yJs6m2/6iLMwfVzKOm6QFCAWik/YIJPoL5CHGrRgiCDk3vy6RsXg3kHrjESd6GXR
lBRP9aNk0ik1b34XEBt/
=cYq3
-----END PGP SIGNATURE-----
--==========DAAFBDC6A737C6B1BDE9==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9F42699EA35CAC7A011308F0>