From owner-freebsd-current@FreeBSD.ORG  Tue Sep 18 17:01:40 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DF169106564A;
	Tue, 18 Sep 2012 17:01:40 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
	[IPv6:2001:7b8:2ff:146::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 9B2738FC14;
	Tue, 18 Sep 2012 17:01:40 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:ecff:a137:3a22:244] (unknown
	[IPv6:2001:7b8:3a7:0:ecff:a137:3a22:244])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id D60B65C59;
	Tue, 18 Sep 2012 19:01:38 +0200 (CEST)
Message-ID: <5058A8EF.8060001@FreeBSD.org>
Date: Tue, 18 Sep 2012 19:01:35 +0200
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:16.0) Gecko/20120905 Thunderbird/16.0
MIME-Version: 1.0
To: David Wolfskill <david@catwhisker.org>
References: <20120918125303.GN3357@albert.catwhisker.org>
In-Reply-To: <20120918125303.GN3357@albert.catwhisker.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Jim Harris <jimharris@freebsd.org>, current@freebsd.org
Subject: Re: buildworld broke in sbin/nvmecontrol; r240620 suspected
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2012 17:01:41 -0000

On 2012-09-18 14:53, David Wolfskill wrote:
...
> using clang as the C compiler:
>
> ...
> ===> sbin/nvmecontrol (all)
> clang -O2 -pipe  -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /usr/src/sbin/nvmecontrol/nvmecontrol.c
> /usr/src/sbin/nvmecontrol/nvmecontrol.c:77:6: error: cast from 'struct nvme_controller_data *' to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
>          p = (uint32_t *)cdata;
>              ^~~~~~~~~~~~~~~~~

Since this tool (nvmecontrol) is currently only compiled for amd64 and
i386, we might as well ignore these alignment warnings, or cast them
away.

Jim, I don't expect this tool to ever be applicable to non-x86 arches,
but can you please confirm that?