From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Feb 22 07:00:01 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5380436E for ; Sat, 22 Feb 2014 07:00:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3F0DC1884 for ; Sat, 22 Feb 2014 07:00:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1M701Pn079012 for ; Sat, 22 Feb 2014 07:00:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1M701JF079011; Sat, 22 Feb 2014 07:00:01 GMT (envelope-from gnats) Date: Sat, 22 Feb 2014 07:00:01 GMT Message-Id: <201402220700.s1M701JF079011@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Robert Sevat Subject: RE: ports/186865: [patch] change rc.d script for security/strongswan X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Robert Sevat List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Feb 2014 07:00:01 -0000 The following reply was made to PR ports/186865; it has been noted by GNATS. From: Robert Sevat To: "bug-followup@FreeBSD.org" , "jason.unovitch@gmail.com" Cc: Subject: RE: ports/186865: [patch] change rc.d script for security/strongswan Date: Sat, 22 Feb 2014 07:51:01 +0100 --_7ada49d0-1371-4c15-bc89-3584d39d4624_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hey Jason=2C I've tested your changes to the rc script and it works as it is supposed to= . Kind Regards=2C Robert Sevat > Date: Thu=2C 20 Feb 2014 21:11:01 -0500 > From: jason.unovitch@gmail.com > To: robert.sevat@live.nl > CC: bug-followup@FreeBSD.org > Subject: Re: ports/186865: [patch] change rc.d script for security/strong= swan >=20 > Robert=2C > There's actually a few things that can use some tweaking per RC lint. =20 > I've attached a fixed version of the RC script for you to try along with= =20 > a patch that fixes the first 4 of the RC lint issues. It makes sense to= =20 > me as the one-line function results in much less clutter above but the=20 > maintainer/committer can decide on exactly what do do with that. >=20 > RC Lint before: > Checking strongswan > ERROR:root:[0]: Order of rc file incorrect > ERROR:root:[0]: Order of variables incorrect > ERROR:root:[13]: Do not quote values unless necessary > ERROR:root:[14]: rcvar is not set correctly > ERROR:root:[27]: One-line functions discouraged=3B put command directly i= n=20 > variable >=20 > RC Lint after: > Checking strongswan > ERROR:root:[27]: One-line functions discouraged=3B put command directly i= n=20 > variable >=20 > Jason = --_7ada49d0-1371-4c15-bc89-3584d39d4624_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Hey Jason=2C

I've tested = your changes to the rc script and it works as it is supposed to.

Kin= d Regards=2C

Robert Sevat


>=3B Date: Thu=2C 20 Feb= 2014 21:11:01 -0500
>=3B From: jason.unovitch@gmail.com
>=3B To:= robert.sevat@live.nl
>=3B CC: bug-followup@FreeBSD.org
>=3B Subj= ect: Re: ports/186865: [patch] change rc.d script for security/strongswan>=3B
>=3B Robert=2C
>=3B There's actually a few things that = can use some tweaking per RC lint.
>=3B I've attached a fixed versio= n of the RC script for you to try along with
>=3B a patch that fixes = the first 4 of the RC lint issues. It makes sense to
>=3B me as the = one-line function results in much less clutter above but the
>=3B mai= ntainer/committer can decide on exactly what do do with that.
>=3B >=3B RC Lint before:
>=3B Checking strongswan
>=3B ERROR:root:= [0]: Order of rc file incorrect
>=3B ERROR:root:[0]: Order of variable= s incorrect
>=3B ERROR:root:[13]: Do not quote values unless necessary=
>=3B ERROR:root:[14]: rcvar is not set correctly
>=3B ERROR:root= :[27]: One-line functions discouraged=3B put command directly in
>=3B= variable
>=3B
>=3B RC Lint after:
>=3B Checking strongswan=
>=3B ERROR:root:[27]: One-line functions discouraged=3B put command d= irectly in
>=3B variable
>=3B
>=3B Jason
=
= --_7ada49d0-1371-4c15-bc89-3584d39d4624_--