From nobody Tue Nov 14 00:29:06 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4STnGp3CKJz50NDZ; Tue, 14 Nov 2023 00:29:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4STnGp2Qd6z4Mv1; Tue, 14 Nov 2023 00:29:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699921746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k+xtdnb9Ngb0ES/27MA3tyrFITFldfDvetCHyYwwKNE=; b=T8PX1rk8f4zTYE5yKo19CcuFVqpvzA7U9xJFkwt3wbwNQGgMHh9oXMxQfSd5+CEyDYo01k ffBT3NLsThSHd4RuSiUHYv0upQIbn30v6M81L4mSuPID3PiVQS4q6kaZCxW8kOWcObQw+F K7l9NqG5Eo7440ze15dK46jzIEu9+SATaE5lEDqU0fBZgM5bNUf3D+SLsbgYVmh6snA28j dUGwz7GdyEDd0D6M3kS6vFUhHTbpQTunnxfNGNxB79SinCCpV4Zkdl03j3XbEoWBvgcyi8 d0aWGb+lCsfo1ED7S0jV5zC3vKAdb3ZAI+JKMcPVoWZSDq+Yt6vBIyzeW8KaVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699921746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k+xtdnb9Ngb0ES/27MA3tyrFITFldfDvetCHyYwwKNE=; b=oZ5g9eZhrSgbBw8aQ3QUNJOqsaMLE8yDaYLcv5UXcFQQO2mwO353Wo265U8MFuRXg94cab whcBrvJHsGeySsGmAyQC1UYSENcC3mmqxuAUPP4R3zCZJ7aTUPYV+brm4EgQhs6+YHuXaO gwc8xohuAPS5/HjnRjGOyJJYk0yDM5KouDvJ4+eh/PSvRjprzzQQBrRsazIXTZYk/GhSC5 hyPOA9vGwVmu+Arks3JMHhOY7t7iwJfiLVJZweT9BuAkP44DfbUjHBrV1T5Dwp94O0Fi9Q SUpErAGX0RXxddF8dT3HPCy5o7zniYuYa4HaTK08gCM9Fu3vGUrvvEVkl6yj/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699921746; a=rsa-sha256; cv=none; b=MDhcKfORBKe3NfecwF7L+UHUbrWk735i9tYHU+DxNWVj52GNpDO1m2xT9yhgrhYBOd1NG4 gOliLH238c6G8F5YIvAXa1wBj+Fszl7MadjQ94Pmq5z2GAX/wSR08bRoZp2qbeI29HXnBy M95ersIU7sDsU3p6tF4VG7tpgCjGOLpG/PXnIuFar2EIIjR8d9fsYKezSpC75GVbMsruc3 NHv2Ony4se7pz2G51PkSILTW5Ljbtcrw/unO/lq+oSacQjxFnbMNFNaB3t+aVCTisLaL/K pPowuNpSANnOr+Ymuswp0hy5xAcTTZupYzQsS6S4CvmhtYhye5toMEdQvagVtg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4STnGp1W2vzBwv; Tue, 14 Nov 2023 00:29:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3AE0T65H064692; Tue, 14 Nov 2023 00:29:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3AE0T63Z064689; Tue, 14 Nov 2023 00:29:06 GMT (envelope-from git) Date: Tue, 14 Nov 2023 00:29:06 GMT Message-Id: <202311140029.3AE0T63Z064689@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: d0ec1aadcb41 - stable/13 - linuxkpi: races between linux_queue_delayed_work_on() and linux_cancel_delayed_work_sync() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d0ec1aadcb4183caad8e67d9ceb4fede8e680420 Auto-Submitted: auto-generated The branch stable/13 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=d0ec1aadcb4183caad8e67d9ceb4fede8e680420 commit d0ec1aadcb4183caad8e67d9ceb4fede8e680420 Author: Konstantin Belousov AuthorDate: 2023-11-04 07:45:48 +0000 Commit: Konstantin Belousov CommitDate: 2023-11-13 22:30:25 +0000 linuxkpi: races between linux_queue_delayed_work_on() and linux_cancel_delayed_work_sync() (cherry picked from commit 05fe82455f263ad107a860ce20dd89e1a5c1619c) --- sys/compat/linuxkpi/common/src/linux_work.c | 36 ++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_work.c b/sys/compat/linuxkpi/common/src/linux_work.c index 990ba5d20fd5..888ac97dbff6 100644 --- a/sys/compat/linuxkpi/common/src/linux_work.c +++ b/sys/compat/linuxkpi/common/src/linux_work.c @@ -221,16 +221,19 @@ linux_queue_delayed_work_on(int cpu, struct workqueue_struct *wq, [WORK_ST_EXEC] = WORK_ST_TIMER, /* start timeout */ [WORK_ST_CANCEL] = WORK_ST_TIMER, /* start timeout */ }; + bool res; if (atomic_read(&wq->draining) != 0) return (!work_pending(&dwork->work)); + mtx_lock(&dwork->timer.mtx); switch (linux_update_state(&dwork->work.state, states)) { case WORK_ST_EXEC: case WORK_ST_CANCEL: if (delay == 0 && linux_work_exec_unblock(&dwork->work) != 0) { dwork->timer.expires = jiffies; - return (true); + res = true; + goto out; } /* FALLTHROUGH */ case WORK_ST_IDLE: @@ -240,20 +243,21 @@ linux_queue_delayed_work_on(int cpu, struct workqueue_struct *wq, if (delay == 0) { linux_delayed_work_enqueue(dwork); } else if (unlikely(cpu != WORK_CPU_UNBOUND)) { - mtx_lock(&dwork->timer.mtx); callout_reset_on(&dwork->timer.callout, delay, &linux_delayed_work_timer_fn, dwork, cpu); - mtx_unlock(&dwork->timer.mtx); } else { - mtx_lock(&dwork->timer.mtx); callout_reset(&dwork->timer.callout, delay, &linux_delayed_work_timer_fn, dwork); - mtx_unlock(&dwork->timer.mtx); } - return (true); + res = true; + break; default: - return (false); /* already on a queue */ + res = false; + break; } +out: + mtx_unlock(&dwork->timer.mtx); + return (res); } void @@ -467,8 +471,8 @@ linux_cancel_delayed_work(struct delayed_work *dwork) * fashion. It returns non-zero if the work was successfully * cancelled. Else the work was already cancelled. */ -bool -linux_cancel_delayed_work_sync(struct delayed_work *dwork) +static bool +linux_cancel_delayed_work_sync_int(struct delayed_work *dwork) { static const uint8_t states[WORK_ST_MAX] __aligned(8) = { [WORK_ST_IDLE] = WORK_ST_IDLE, /* NOP */ @@ -478,7 +482,6 @@ linux_cancel_delayed_work_sync(struct delayed_work *dwork) [WORK_ST_CANCEL] = WORK_ST_IDLE, /* cancel and drain */ }; struct taskqueue *tq; - bool retval = false; int ret, state; bool cancelled; @@ -490,7 +493,7 @@ linux_cancel_delayed_work_sync(struct delayed_work *dwork) switch (state) { case WORK_ST_IDLE: mtx_unlock(&dwork->timer.mtx); - return (retval); + return (false); case WORK_ST_TIMER: case WORK_ST_CANCEL: cancelled = (callout_stop(&dwork->timer.callout) == 1); @@ -512,6 +515,17 @@ linux_cancel_delayed_work_sync(struct delayed_work *dwork) } } +bool +linux_cancel_delayed_work_sync(struct delayed_work *dwork) +{ + bool res; + + res = false; + while (linux_cancel_delayed_work_sync_int(dwork)) + res = true; + return (res); +} + /* * This function waits until the given work structure is completed. * It returns non-zero if the work was successfully