From nobody Thu Dec 7 05:50:21 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sm3K85sq0z53fLG for ; Thu, 7 Dec 2023 05:50:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sm3K84Cskz3XDd for ; Thu, 7 Dec 2023 05:50:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a1ceae92ab6so63201866b.0 for ; Wed, 06 Dec 2023 21:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1701928234; x=1702533034; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2qTQn8b9WWDeO3SRmqtZb4vq5fWyGavLR7gZE9zVegg=; b=MjeJ4R5aaK3dn8lj8U2ARIOxLsfjBND+Gza7e6TBP3x4xg2Hopeb8TP6WgTqrlFHJZ MClh0qLSOWUog2zQ2RHFjWpe2uI2u6Z6SZOvhIAbvQdY1YVnFH8Zq0AZghGZ2Ul2suUE onHqc3Q250npD/p2VK86jg7t3rKSp8qHMZZUL8ntRaTXZz+1bHKJGYtO1OfqrWYcMPao QdJYzBObRqGBzMcKaIjoDmmHxYO/AbjEZacECP0KfpNtIQG8qr3vdHjkyApzv+0/IoTn 1CqeB6dQuF8/fvGUeRbZJ7XLRD01PJAoXnk2sCKg59Y7gGNFHqCMSx4Skmx3YknW6MAh P7Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701928234; x=1702533034; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2qTQn8b9WWDeO3SRmqtZb4vq5fWyGavLR7gZE9zVegg=; b=XpWQVeYObb+FdMD7Ck/jYOiXtuTuQgUKzpvE3g035aA6VDqjmLInYgmSmKYIqnYO7+ 3J72/Ezmj6HR5x/QBVumXF+faQd8W7LvTOJusm9bzPJ9GJsnrMnoNcuu5lSBX7KaMLHx aJRJjHSO0f0A46dQkjDI0opFI9P+NwTBkN9edsloJByoJVypBzPh7FWUKrKRkLGXN0tw GtNIRiN6uDXczJAyYZzTWvqNJxQIQ7G0MT80iM+o1e4KPqd9YYfSAQ5F6tx+DLhC7gqi Bar8jLzLRg2DRCP66qgu8WQ41J8SuOxn15f7GTTk3PYTMYc+WyvIq+5r5SDV0AEBCjNK ptsg== X-Gm-Message-State: AOJu0Yx/Pd6NmsOB54fH/sWLoMMjW/vpORYW55teDL0um04ukLOFJqFw Ma1TacLa0Ow5t4Mv2ulrEVgC43QVDt3D8MIa5qSnjw== X-Google-Smtp-Source: AGHT+IHO6qgNkVsrRnfQ94XYvrIqJY1qlkqHT3uLhF+JBu/BfoIeW3TkjqUnlk7WEZAxT6cxAMrs0nt5nme6b6jCj6Q= X-Received: by 2002:a17:906:10ce:b0:a1e:cb47:3785 with SMTP id v14-20020a17090610ce00b00a1ecb473785mr203607ejv.68.1701928233877; Wed, 06 Dec 2023 21:50:33 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202312061652.3B6GqOuf068349@gitrepo.freebsd.org> <44E8C9F3-84DD-4E51-B2A4-FB56E2A08F30@FreeBSD.org> In-Reply-To: From: Warner Losh Date: Wed, 6 Dec 2023 22:50:21 -0700 Message-ID: Subject: Re: git: 6b96125afdf2 - main - cap_net.3: remove a copypasta To: Alan Somers Cc: Zhenlei Huang , src-committers , "" , "" , li-Wen Hsu Content-Type: multipart/alternative; boundary="000000000000d05322060be50b48" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4Sm3K84Cskz3XDd --000000000000d05322060be50b48 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 6, 2023, 8:59 PM Alan Somers wrote: > On Wed, Dec 6, 2023 at 6:55=E2=80=AFPM Zhenlei Huang w= rote: > > > > > > > > > On Dec 7, 2023, at 12:52 AM, Alan Somers wrote: > > > > > > The branch main has been updated by asomers: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D6b96125afdf245ae61dd82b59891ad0= d6aab0066 > > > > > > commit 6b96125afdf245ae61dd82b59891ad0d6aab0066 > > > Author: Alan Somers > > > AuthorDate: 2023-12-05 23:23:29 +0000 > > > Commit: Alan Somers > > > CommitDate: 2023-12-06 16:51:37 +0000 > > > > > > cap_net.3: remove a copypasta > > > > > > This line appears to have been copied from cap_sysctl.3. While I'= m > > > here, reorder and reword the description of cap_net_limit a bit. > > > > > > [skip ci] > > > > I guess we can 'skip ci' implicitly for document or typo changes. > > Can we? The skipping logic is builtin to Jenkins, Github Workflows, > and Cirrus. I don't think it would be easy to program any of those to > detect which changes can be safely skipped. > The message currently is a nearly nop for our setup. Jenkins runs arent triggered by a commit. Cirrus CI already can't maje it more than a few days into the month. Commits aren't gated into main by CI. So IMHO, it just adds noise. Let's drop it until it has an actual beneficial effect. Metadata like that doesn't really belong in the git log. As this situation changes, we can reevaluate... Again just my opinion... Warner -Alan > --000000000000d05322060be50b48 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Dec 6, 2023, 8:59 PM Alan Somers <asomers@freebsd.org> wrote:
On Wed, Dec 6, 2023 at 6:55=E2=80=AFPM Zhen= lei Huang <zlei@freebsd.org> wrote:
>
>
>
> > On Dec 7, 2023, at 12:52 AM, Alan Somers <asomers@freebsd.org= > wrote:
> >
> > The branch main has been updated by asomers:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D6b96125afdf245ae61dd82b59= 891ad0d6aab0066
> >
> > commit 6b96125afdf245ae61dd82b59891ad0d6aab0066
> > Author:=C2=A0 =C2=A0 =C2=A0Alan Somers <asomers@FreeBSD.org>= ;
> > AuthorDate: 2023-12-05 23:23:29 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Alan Somers <asomers@FreeBSD.org>= ;
> > CommitDate: 2023-12-06 16:51:37 +0000
> >
> >=C2=A0 =C2=A0 cap_net.3: remove a copypasta
> >
> >=C2=A0 =C2=A0 This line appears to have been copied from cap_sysct= l.3.=C2=A0 While I'm
> >=C2=A0 =C2=A0 here, reorder and reword the description of cap_net_= limit a bit.
> >
> >=C2=A0 =C2=A0 [skip ci]
>
> I guess we can 'skip ci' implicitly for document or typo chang= es.

Can we?=C2=A0 =C2=A0The skipping logic is builtin to Jenkins, Github Workfl= ows,
and Cirrus.=C2=A0 I don't think it would be easy to program any of thos= e to
detect which changes can be safely skipped.

The message currently is a nearl= y nop for our setup. Jenkins runs arent triggered by a commit. Cirrus CI al= ready can't maje it more than a few days into the month. Commits aren&#= 39;t gated into main by CI. So IMHO, it just adds noise. Let's drop it = until it has an actual beneficial effect. Metadata like that doesn't re= ally belong in the git log.

As this situation changes, we can reevaluate...
=
Again just my opinion...

Warner

-Alan
--000000000000d05322060be50b48--