From owner-svn-src-head@freebsd.org Thu Dec 22 23:16:18 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 260FEC8DE32; Thu, 22 Dec 2016 23:16:18 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x242.google.com (mail-pg0-x242.google.com [IPv6:2607:f8b0:400e:c05::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E7FC8CC3; Thu, 22 Dec 2016 23:16:17 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x242.google.com with SMTP id g1so19791098pgn.0; Thu, 22 Dec 2016 15:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=ifgxMxLuqcU0+WHSuHeYrD/z+RoDy5xE/sfz4xW4s7o=; b=Ujniz1U79WDBMajw3BQB0koAhpQKklt29QHyZhY0RRSfQHlJpzERP5M3q+ZQdp16Uj yXSXCbMXob4W59m7q5+008sHxqzAAlhA9lfrcJ4EEnYCIBztA8vhsLn0cr3ZmtIX8uJO QNMRm0K4bys6o9o0oss0Dq+IUK1DkTlw4UFpxIpyoxR0h+ENyPT655X/rQEU1SSK6+0M UWF+OhhERf93ncfOfAeuac/PZkq0lqreGcGZogyu2mvAZf60nnQhIzh9vUS2EaP6Kv7W oiBmeTdiCTBEzvAOKdep0m++2IgwMF7sW3uNjHkgcFrN/Wb5t9Lg0ltsG8r32x84aOGk MSyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=ifgxMxLuqcU0+WHSuHeYrD/z+RoDy5xE/sfz4xW4s7o=; b=q0N9U5Ft2yYND0uZYeMa38vcNnrncf4TLq8ZK3Z6k1GTresh00JpbuR75ZB4Gmrfxy jw8yFeyamYUKPdQ1wLJm5lbH90v/DsC8v34EjVKfNVmhasxRZwGN1GPxfjmph0v0Zg9q Opj36UBSZEAtDm/u9N4W44EQBjYNYMczAim4GonMgjor+wddrVVnOSLMwVEcaWZfEn/k 8UbRJ0a9HYcW39+kCF+s5qLaEuXuyz/9gsqHXQn2PTEgI0alcBYSfeiExQEAy3/95Do2 hJJuMCH4wNb4c0PAH4Hpm5gHKkTawCO1mALk5WUdzGO7X8aYB0J1WmEbV2q/Sux9VR6G 4sSA== X-Gm-Message-State: AIkVDXINuMPU/o6qAL5nL5p5KFHVaoOPhsp3m4fU/MK7LXhLRtK/fbMnz3s+E9gqHMiytQ== X-Received: by 10.99.19.65 with SMTP id 1mr21210911pgt.71.1482448577290; Thu, 22 Dec 2016 15:16:17 -0800 (PST) Received: from fuji-wireless.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id c71sm57436173pga.22.2016.12.22.15.16.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2016 15:16:16 -0800 (PST) From: "Ngie Cooper (yaneurabeya)" Message-Id: Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: svn commit: r310433 - head/lib/libc/stdio Date: Thu, 22 Dec 2016 15:16:15 -0800 In-Reply-To: Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: cem@freebsd.org References: <201612222230.uBMMUge9075128@repo.freebsd.org> X-Mailer: Apple Mail (2.3259) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 23:16:18 -0000 > On Dec 22, 2016, at 2:39 PM, Conrad Meyer wrote: >=20 > This was unjustified and inappropriate. Conrad, =46rom the committer=E2=80=99s guide ( = https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/arti= cle.html#developer.relations = ): If you are unsure about a commit for any reason at all, have it reviewed = by -hackers before committing. Better to have it flamed then and there = rather than when it is part of the repository. If you do happen to = commit something which results in controversy erupting, you may also = wish to consider backing the change out again until the matter is = settled. Remember =E2=80=93 with a version control system we can always = change it back. Per the commit message, the change wasn=E2=80=99t reviewed = before commit (" Reviewed by: no one, unfortunately=E2=80=9D). More = than a handful of people requested that the commit be reverted/changed. = There wasn=E2=80=99t an issue with the content created =E2=80=94 there = was just an issue with how %b was implemented (especially when it = impedes being able to cross-compile FreeBSD on other operating systems = or port code to those operating systems). Dmitriy=E2=80=99s comment about adding snprintb(3) from NetBSD = makes a lot of sense and will reintroduce the code that you added here, = and I fully agree and support his suggestion. For what it=E2=80=99s worth from personal experience, it=E2=80=99s= really a pain when non-standard things get leaked into FreeBSD, or when = you have to port software to other operating systems that use = non-standard interfaces (I usually have to do this moving Linux code to = FreeBSD). Take the format -fformat* string functionality in OneFS =E2=80=94= it=E2=80=99s unfortunate that we can=E2=80=99t use a standard compiler = to compile OneFS out of the box and instead have to bootstrap a compiler = which is intelligent enough to understand how the custom format strings = work, just to compile user space/a kernel. Thank you, -Ngie=