From owner-freebsd-bugs Sun May 6 3:10: 7 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id B72CA37B423 for ; Sun, 6 May 2001 03:10:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f46AA2W96013; Sun, 6 May 2001 03:10:02 -0700 (PDT) (envelope-from gnats) Date: Sun, 6 May 2001 03:10:02 -0700 (PDT) Message-Id: <200105061010.f46AA2W96013@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Bruce Evans Subject: Re: conf/27089: Missing include in /usr/include/sys/conf.h Reply-To: Bruce Evans Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR conf/27089; it has been noted by GNATS. From: Bruce Evans To: Kris Kennaway Cc: freebsd-gnats-submit@FreeBSD.ORG Subject: Re: conf/27089: Missing include in /usr/include/sys/conf.h Date: Sun, 6 May 2001 20:01:03 +1000 (EST) On Sat, 5 May 2001, Kris Kennaway wrote: > On Sat, May 05, 2001 at 07:09:17AM +0000, Udo Schweigert wrote: > > > /usr/include/sys/conf.h references struct timespec which is defined in > > /usr/include/sys/time.h. Since /usr/include/sys/time.h is not included by > > /usr/include/sys/conf.h this results in an error (for example when trying > > to build the sysutils/xosview port). > > > #include > > +#include > > This is probably the wrong thing to do..the correct thing is to fix > the broken software which makes that assumption. It's not clear if the broken software is or xosview. A few applications in /usr/src include . At least fstat/fstat.c sort of needs to, since it wants convert kernel dev_t's to userland dev_t's. Kernel dev_t's are now pointers, and is the only place that declares the struct that they point to. OTOH, top/machine.c includes for no reason. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message