From owner-cvs-all Thu Sep 13 22: 3: 5 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 8FB0A37B410; Thu, 13 Sep 2001 22:02:56 -0700 (PDT) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f8E52hU48038; Fri, 14 Sep 2001 01:02:43 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <3BA133F0.17179.75B20696@localhost> References: <3BA133F0.17179.75B20696@localhost> Date: Fri, 14 Sep 2001 01:02:40 -0400 To: dan@langille.org, Josef Karthauser From: Garance A Drosihn Subject: Re: Proposed patch to log_accum.pl Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 10:32 PM -0400 9/13/01, Dan Langille wrote: >I like that idea, from a FreshPorts II point of view. One of the >technical problems is tracking which version of a file has been >deleted. Having the above helps greatly. > >A more important item, from a FreshPorts II point of view is the >path name is often incomplete. That is, the first directory is >often omitted. A few example from recent commits: > > Added files: > biology/tinker/files tview > > Removed files: > biology/tinker/files patch-ag > > Added files: > usr.sbin/kldxref Makefile ef.c ef.h fileformat kldxref.8 > kldxref.c > >The logistics of determining the actual directory prefix is a bit >beyond hard. It would be simplified by a log entry such ... If you're running into the same challenge I ran into with cvsmerge, you won't need a change to this part of the log entry. The pathname is only trimmed-down in the "first section" of the log entry. In the section that Josef is changing, which lists the revision numbers, you always get the full path name. Right now my script *has* to parse the above section, because there is no other way to know about added and removed files. After Josef's proposed change, it should be true that scripts can completely ignore this first section of the commit message, and only parse the later section (and that does have the full pathname). The first section is trying to be as compact as possible, to make it easy for humans to skim thru. My guess is that it won't need to be changed. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message