From owner-svn-src-head@FreeBSD.ORG  Fri Jun 19 10:16:51 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B42EE535;
 Fri, 19 Jun 2015 10:16:51 +0000 (UTC)
 (envelope-from theraven@FreeBSD.org)
Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cloud.theravensnest.org",
 Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7CDA8402;
 Fri, 19 Jun 2015 10:16:51 +0000 (UTC)
 (envelope-from theraven@FreeBSD.org)
Received: from [192.168.0.7] (cpc16-cmbg15-2-0-cust60.5-4.cable.virginm.net
 [86.5.162.61]) (authenticated bits=0)
 by theravensnest.org (8.15.1/8.15.1) with ESMTPSA id t5JAGiYR066324
 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO);
 Fri, 19 Jun 2015 10:16:49 GMT (envelope-from theraven@FreeBSD.org)
X-Authentication-Warning: theravensnest.org: Host
 cpc16-cmbg15-2-0-cust60.5-4.cable.virginm.net [86.5.162.61] claimed to be
 [192.168.0.7]
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Subject: Re: svn commit: r268137 - head/sys/sys
From: David Chisnall <theraven@FreeBSD.org>
In-Reply-To: <201407020845.s628jRG5031824@svn.freebsd.org>
Date: Fri, 19 Jun 2015 11:16:40 +0100
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <5BE3492F-86A0-4CE3-A27C-8DB5EB662C64@FreeBSD.org>
References: <201407020845.s628jRG5031824@svn.freebsd.org>
To: Hans Petter Selasky <hselasky@FreeBSD.org>
X-Mailer: Apple Mail (2.2098)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Jun 2015 10:16:51 -0000

I only just caught this (having seen the fallout from NetBSD doing the =
same thing in a shipping release and the pain that it=E2=80=99s caused):

__weak is a reserved keyword in Objective-C, please pick another name =
for this.  This in cdefs.h makes it impossible to include any FreeBSD =
standard headers in Objective-C programs (of which we have a couple of =
hundred in ports) if they use any of the modern Objective-C language =
modes.

David

> On 2 Jul 2014, at 09:45, Hans Petter Selasky <hselasky@FreeBSD.org> =
wrote:
>=20
> Author: hselasky
> Date: Wed Jul  2 08:45:26 2014
> New Revision: 268137
> URL: http://svnweb.freebsd.org/changeset/base/268137
>=20
> Log:
>  Define a "__weak" macro for declaring symbols "weak".
>=20
> Modified:
>  head/sys/sys/cdefs.h
>=20
> Modified: head/sys/sys/cdefs.h
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/sys/cdefs.h	Wed Jul  2 05:45:40 2014	=
(r268136)
> +++ head/sys/sys/cdefs.h	Wed Jul  2 08:45:26 2014	=
(r268137)
> @@ -210,7 +210,9 @@
> #define	__packed
> #define	__aligned(x)
> #define	__section(x)
> +#define	__weak
> #else
> +#define	__weak		__attribute__((__weak__))
> #if !__GNUC_PREREQ__(2, 5) && !defined(__INTEL_COMPILER)
> #define	__dead2
> #define	__pure2
>=20