From owner-svn-src-head@FreeBSD.ORG Mon Apr 1 16:30:21 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 6C38241E; Mon, 1 Apr 2013 16:30:21 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) by mx1.freebsd.org (Postfix) with ESMTP id 4346A165; Mon, 1 Apr 2013 16:30:21 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8CCA6B963; Mon, 1 Apr 2013 12:30:20 -0400 (EDT) From: John Baldwin To: Will Andrews Subject: Re: svn commit: r248836 - head/gnu/usr.bin/gdb/kgdb Date: Mon, 1 Apr 2013 12:19:48 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <201303281704.r2SH4x3J025620@svn.freebsd.org> In-Reply-To: <201303281704.r2SH4x3J025620@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201304011219.48988.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 01 Apr 2013 12:30:20 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 16:30:21 -0000 On Thursday, March 28, 2013 1:04:59 pm Will Andrews wrote: > Author: will > Date: Thu Mar 28 17:04:59 2013 > New Revision: 248836 > URL: http://svnweb.freebsd.org/changeset/base/248836 > > Log: > KGDB: Allow modules to be loaded from the specified kernel's directory. > > When looking up the absolute path for a kld, call find_kld_path() first. > This enables locating the module in a different directory than the one > stored in kernel memory. > > With this change, kgdb can now be run on a kernel & vmcore whose associated > modules are located in the same directory as the kernel. This makes > independent triaging of problems much easier. > > This change also does not break the normal kgdb use case where no arguments > are specified; in that case kgdb loads the running kernel and its modules. > > Reviewed by: adrian > Approved by: ken (mentor) > Sponsored by: Spectra Logic > MFC after: 1 month Sorry I didn't comment on this earlier (was away from mail). This looks good to me. -- John Baldwin