From owner-svn-src-head@FreeBSD.ORG Sat Dec 21 14:50:06 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9AA5016A; Sat, 21 Dec 2013 14:50:06 +0000 (UTC) Received: from smtpauth2.wiscmail.wisc.edu (wmauth2.doit.wisc.edu [144.92.197.222]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 663041A15; Sat, 21 Dec 2013 14:50:06 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from avs-daemon.smtpauth2.wiscmail.wisc.edu by smtpauth2.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MY500G00V4L6W00@smtpauth2.wiscmail.wisc.edu>; Sat, 21 Dec 2013 08:49:59 -0600 (CST) X-Spam-PmxInfo: Server=avs-2, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.12.21.143916, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from wanderer.tachypleus.net (172-12-164-50.lightspeed.wlfrct.sbcglobal.net [172.12.164.50]) by smtpauth2.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MY50015TVV89720@smtpauth2.wiscmail.wisc.edu>; Sat, 21 Dec 2013 08:49:58 -0600 (CST) Message-id: <52B5AA94.3060009@freebsd.org> Date: Sat, 21 Dec 2013 08:49:56 -0600 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 To: Devin Teske , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts References: <201312161550.rBGFox0N001344@svn.freebsd.org> <52AF2502.1060503@freebsd.org> In-reply-to: <52AF2502.1060503@freebsd.org> X-Enigmail-Version: 1.5.2 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Dec 2013 14:50:06 -0000 Could you please revert this and move the fix to the correct place? -Nathan On 12/16/13 10:06, Nathan Whitehorn wrote: > Please add this to release/rc.local instead under the console setup. > There is no guarantee that "auto" is running from an environment where > this is defined -- for example, it may be running from a serial > console or an xterm -- and the actual installer should not be polluted > with assumptions about the media from which it runs. > -Nathan > > On 12/16/13 09:50, Devin Teske wrote: >> Author: dteske >> Date: Mon Dec 16 15:50:59 2013 >> New Revision: 259468 >> URL: http://svnweb.freebsd.org/changeset/base/259468 >> >> Log: >> Add a fix for Long-standing problem with VMware. Described in >> below links: >> https://communities.vmware.com/thread/107230 >> https://communities.vmware.com/docs/DOC-11677 >> Basically, ignore the ``function 62'' and ``function 63'' >> interpretations >> of the left/right command key when we're in the lengthiest portion >> of the >> installation (initiated by the `auto' module). >> The net effect is that you can now (once you've started the >> installer from >> the media) escape the VM without prematurely terminating the >> current action >> due to spurious escape sequence. >> MFC after: 3 days >> >> Modified: >> head/usr.sbin/bsdinstall/scripts/auto >> >> Modified: head/usr.sbin/bsdinstall/scripts/auto >> ============================================================================== >> >> --- head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:08:30 >> 2013 (r259467) >> +++ head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:50:59 >> 2013 (r259468) >> @@ -49,6 +49,10 @@ error() { >> ############################################################ MAIN >> +# Don't send ESC on function-key 62/63 (left/right command key) >> +f_quietly kbdcontrol -f 62 '' >> +f_quietly kbdcontrol -f 63 '' >> + >> f_dprintf "Began Installation at %s" "$( date )" >> rm -rf $BSDINSTALL_TMPETC >